Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Update golang.org/x/... dependencies #34368

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

What does this PR do?

Update all golang.org/x/... dependencies.

Motivation

Keep dependencies up-to-date, benefit from bug fixes and new features.

Describe how you validated your changes

CI is considered enough to validate changes.

@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner February 24, 2025 18:01
@agent-platform-auto-pr agent-platform-auto-pr bot added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-runtimes labels Feb 24, 2025
@agent-platform-auto-pr agent-platform-auto-pr bot requested review from a team and pgimalac February 24, 2025 18:01
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Feb 24, 2025
@agent-platform-auto-pr
Copy link
Contributor Author

Uncompressed package size comparison

Comparison with ancestor e3f7cade9bcec8d5cf32910b6ed8856eb0b68156

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 840.06MB 840.06MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 849.83MB 849.83MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 849.83MB 849.83MB 0.50MB
datadog-agent-arm64-deb 0.00MB 830.17MB 830.17MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 839.92MB 839.92MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.28MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.02MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.26MB 59.26MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.33MB 59.33MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor Author

Static quality checks ❌

Please find below the results from static quality gates

Error

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_rpm_amd64 DataNotFound 847.82MiB DataNotFound 215.76MiB
Gate failure full details
Quality gate Error type Error message
static_quality_gate_agent_rpm_amd64 StackTrace Traceback (most recent call last):
File "/go/src/github.com/DataDog/datadog-agent/tasks/quality_gates.py", line 121, in parse_and_trigger_gates
gate_mod.entrypoint(**gate_inputs)
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/static_quality_gate_agent_rpm_amd64.py", line 5, in entrypoint
generic_package_agent_quality_gate(
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 69, in generic_package_agent_quality_gate
package_on_wire_size, package_on_disk_size = calculate_package_size(
^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 10, in calculate_package_size
extract_package(ctx=ctx, package_os=package_os, package_path=package_path, extract_dir=extract_dir)
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 72, in extract_package
return extract_rpm_package(ctx, package_path, extract_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 65, in extract_rpm_package
ctx.run(f"rpm2cpio {package_path}
Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 812.86MiB 847.49MiB 196.85MiB 212.33MiB
static_quality_gate_agent_deb_arm64 803.46MiB 836.66MiB 176.45MiB 192.5MiB
static_quality_gate_agent_rpm_arm64 803.48MiB 836.66MiB 180.83MiB 194.24MiB
static_quality_gate_agent_suse_amd64 812.83MiB 847.82MiB 199.27MiB 215.76MiB
static_quality_gate_agent_suse_arm64 803.46MiB 836.66MiB 180.83MiB 194.24MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 49.7MiB 9.78MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 36.27MiB 48.1MiB 8.49MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.22MiB 69.0MiB 14.88MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.84MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 897.27MiB 931.7MiB 300.91MiB 318.67MiB
static_quality_gate_docker_agent_arm64 911.1MiB 944.08MiB 286.41MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.07GiB 1.1GiB 376.0MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.07GiB 1.1GiB 357.49MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 45.81MiB 57.88MiB 17.28MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 44.45MiB 56.27MiB 16.16MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.94MiB 274.78MiB 106.34MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.92MiB 290.82MiB 101.18MiB 111.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 12726e6b-270f-40e5-8e0b-40e7e0a66683

Baseline: e3f7cad
Comparison: c493dab
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.73 [+0.66, +0.79] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.37 [-0.10, +0.83] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.72, +0.83] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.77, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.61, +0.64] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.30] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.80, +0.81] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.62, +0.62] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.76, +0.74] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.23 [-1.01, +0.55] 1 Logs
file_tree memory utilization -0.33 [-0.39, -0.27] 1 Logs
quality_gate_idle_all_features memory utilization -0.41 [-0.46, -0.36] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.91 [-0.94, -0.87] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.33 [-2.18, -0.48] 1 Logs
quality_gate_logs % cpu utilization -1.92 [-4.74, +0.91] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@pgimalac
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 25, 2025

View all feedbacks in Devflow UI.
2025-02-25 09:12:55 UTC ℹ️ Start processing command /merge


2025-02-25 09:13:09 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-25 12:21:06 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 28m.


2025-02-25 13:06:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 153cd14 into main Feb 25, 2025
459 checks passed
@dd-mergequeue dd-mergequeue bot deleted the update-golang-org-x-13504600607-1 branch February 25, 2025 13:06
@github-actions github-actions bot added this to the 7.65.0 milestone Feb 25, 2025
wdhif pushed a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-runtimes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants