Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/DataDog/go-libddwaf/v3 from 3.5.2 to 3.5.3 #34386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 24, 2025

Bumps github.com/DataDog/go-libddwaf/v3 from 3.5.2 to 3.5.3.

Release notes

Sourced from github.com/DataDog/go-libddwaf/v3's releases.

v3.5.3

What's Changed

Full Changelog: DataDog/go-libddwaf@v3.5.2...v3.5.3

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Feb 24, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 24, 2025
Copy link

cit-pr-commenter bot commented Feb 24, 2025

Go Package Import Differences

Baseline: affd2a9
Comparison: e2c3d8a

binaryosarchchange
agentlinuxamd64
+1, -0
+structs
agentlinuxarm64
+1, -0
+structs
agentwindowsamd64
+1, -0
+structs
agentdarwinamd64
+1, -0
+structs
agentdarwinarm64
+1, -0
+structs
iot-agentlinuxamd64
+1, -0
+structs
iot-agentlinuxarm64
+1, -0
+structs
heroku-agentlinuxamd64
+1, -0
+structs
cluster-agentlinuxamd64
+1, -0
+structs
cluster-agentlinuxarm64
+1, -0
+structs
serverlesslinuxamd64
+1, -0
+structs
serverlesslinuxarm64
+1, -0
+structs

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025

Uncompressed package size comparison

Comparison with ancestor 719fa8d3aa49b77298ae64535eb069dad8da8993

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.08MB ⚠️ 827.74MB 827.66MB 0.50MB
datadog-agent-x86_64-suse 0.08MB ⚠️ 827.74MB 827.66MB 0.50MB
datadog-agent-aarch64-rpm 0.08MB ⚠️ 818.70MB 818.62MB 0.50MB
datadog-agent-amd64-deb 0.08MB ⚠️ 817.95MB 817.87MB 0.50MB
datadog-agent-arm64-deb 0.08MB ⚠️ 808.92MB 808.84MB 0.50MB
datadog-heroku-agent-amd64-deb 0.07MB ⚠️ 443.35MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 62.03MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 62.10MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 62.10MB 62.09MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 59.34MB 59.33MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 59.27MB 59.27MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 791.89MiB 801.8MiB 192.62MiB 202.62MiB
static_quality_gate_agent_deb_arm64 783.23MiB 793.14MiB 174.68MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 791.93MiB 801.79MiB 195.03MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 783.29MiB 793.09MiB 176.44MiB 186.44MiB
static_quality_gate_agent_suse_amd64 791.92MiB 801.81MiB 195.03MiB 205.03MiB
static_quality_gate_agent_suse_arm64 783.29MiB 793.14MiB 176.44MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.67MiB 9.78MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.27MiB 46.27MiB 8.48MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.6MiB 66.4MiB 12.86MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 876.2MiB 886.12MiB 294.23MiB 304.21MiB
static_quality_gate_docker_agent_arm64 890.86MiB 900.79MiB 280.49MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.35MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.59MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.81MiB 55.78MiB 17.28MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.45MiB 54.45MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.96MiB 274.78MiB 106.36MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.91MiB 290.82MiB 101.17MiB 111.12MiB

Copy link

cit-pr-commenter bot commented Feb 24, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 596233b9-a5f6-4fdd-a33d-599bc858d0ef

Baseline: affd2a9
Comparison: e2c3d8a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.85 [-0.02, +1.72] 1 Logs
quality_gate_logs % cpu utilization +0.76 [-2.14, +3.66] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.53 [+0.48, +0.59] 1 Logs
file_tree memory utilization +0.41 [+0.35, +0.46] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.34 [-0.13, +0.80] 1 Logs
quality_gate_idle_all_features memory utilization +0.33 [+0.28, +0.38] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.22 [-0.57, +1.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.80, +0.84] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.76, +0.80] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.31] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.04] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.69, +0.69] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.79, +0.77] 1 Logs
quality_gate_idle memory utilization -0.07 [-0.11, -0.04] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.39 [-1.15, +0.38] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/DataDog/go-libddwaf/v3-3.5.3 branch from 626284d to 0c77a61 Compare February 25, 2025 18:48
Bumps [github.com/DataDog/go-libddwaf/v3](https://github.com/DataDog/go-libddwaf) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/DataDog/go-libddwaf/releases)
- [Commits](DataDog/go-libddwaf@v3.5.2...v3.5.3)

---
updated-dependencies:
- dependency-name: github.com/DataDog/go-libddwaf/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/DataDog/go-libddwaf/v3-3.5.3 branch from 0c77a61 to e2c3d8a Compare February 25, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency short review PR is simple enough to be reviewed quickly team/triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants