Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTAGENT-203] make comp/otelcol/status a module #34395

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Feb 24, 2025

What does this PR do?

Make comp/otelcol/status/def, comp/otelcol/status/impl and pkg/util/prometheus Go modules

Motivation

working towards http://datadoghq.atlassian.net/browse/OTAGENT-203

@songy23 songy23 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/opentelemetry-agent labels Feb 24, 2025
@songy23 songy23 added this to the 7.65.0 milestone Feb 24, 2025
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Feb 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025

Uncompressed package size comparison

Comparison with ancestor e341d88e5928e432dfe0ad3d161171cc56745482

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB 827.66MB 827.66MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 827.66MB 827.66MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 818.62MB 818.62MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.33MB 59.33MB 0.50MB
datadog-agent-amd64-deb 0.00MB 817.87MB 817.87MB 0.50MB
datadog-agent-arm64-deb 0.00MB 808.85MB 808.85MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.28MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.02MB 62.02MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.27MB 59.27MB 0.50MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Feb 25, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f1d4c70c-55c6-4832-95f5-88a0e84452b3

Baseline: e341d88
Comparison: 5427876
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +4.88 [+1.90, +7.85] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.47 [-0.41, +1.35] 1 Logs
file_tree memory utilization +0.26 [+0.20, +0.32] 1 Logs
quality_gate_idle memory utilization +0.21 [+0.18, +0.25] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.12 [-0.67, +0.91] 1 Logs
quality_gate_idle_all_features memory utilization +0.03 [-0.02, +0.08] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.59, +0.65] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.66, +0.68] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.30, +0.29] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.82, +0.81] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.82, +0.79] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.85, +0.79] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.16 [-0.24, -0.09] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.20 [-0.67, +0.27] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.64 [-1.42, +0.14] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@songy23 songy23 force-pushed the yang.song/OTAGENT-203-2 branch from 20abc5d to 0bf0c44 Compare February 25, 2025 03:56
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 791.68MiB 817.79MiB 192.62MiB 204.92MiB
static_quality_gate_agent_deb_arm64 783.19MiB 808.76MiB 174.75MiB 186.5MiB
static_quality_gate_agent_rpm_amd64 791.79MiB 817.82MiB 195.01MiB 208.12MiB
static_quality_gate_agent_rpm_arm64 783.14MiB 808.76MiB 176.42MiB 188.34MiB
static_quality_gate_agent_suse_amd64 791.68MiB 817.82MiB 195.01MiB 208.12MiB
static_quality_gate_agent_suse_arm64 783.02MiB 808.86MiB 176.42MiB 188.33MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.7MiB 9.78MiB 19.8MiB
static_quality_gate_dogstatsd_deb_arm64 36.27MiB 46.3MiB 8.49MiB 18.5MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.7MiB 9.79MiB 19.8MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.7MiB 9.79MiB 19.8MiB
static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 876.12MiB 902.2MiB 294.21MiB 308.43MiB
static_quality_gate_docker_agent_arm64 890.79MiB 916.47MiB 280.47MiB 294.23MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.07GiB 369.33MiB 383.54MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.08GiB 351.57MiB 365.31MiB
static_quality_gate_docker_dogstatsd_amd64 45.81MiB 55.78MiB 17.28MiB 27.29MiB
static_quality_gate_docker_dogstatsd_arm64 44.45MiB 54.47MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.94MiB 274.78MiB 106.35MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.9MiB 290.82MiB 101.19MiB 111.12MiB

@songy23 songy23 force-pushed the yang.song/OTAGENT-203-2 branch from 8b9815c to 5427876 Compare February 25, 2025 16:23
@songy23 songy23 marked this pull request as ready for review February 25, 2025 16:27
@songy23 songy23 requested a review from a team as a code owner February 25, 2025 16:27
@songy23 songy23 requested a review from misteriaud February 25, 2025 16:27
@@ -96,6 +96,8 @@ modules:
used_by_otel: true
comp/otelcol/otlp/testutil:
used_by_otel: true
comp/otelcol/status/def: default
comp/otelcol/status/impl: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these need the following:

    used_by_otel: true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed unless we plan on importing these modules in the OSS collector

Copy link
Member Author

@songy23 songy23 Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question - no, those are only used in the embedded collector (aka in Agent code base), while used_by_otel indicates used in the OSS collector contrib code base

@songy23
Copy link
Member Author

songy23 commented Feb 25, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 25, 2025

View all feedbacks in Devflow UI.
2025-02-25 18:03:13 UTC ℹ️ Start processing command /merge


2025-02-25 18:03:17 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 28m.


2025-02-25 18:44:28 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2102a8e into main Feb 25, 2025
443 of 444 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/OTAGENT-203-2 branch February 25, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/opentelemetry-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants