Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU]: Additional fields for GPUEntity in WMS #34409

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

val06
Copy link
Contributor

@val06 val06 commented Feb 25, 2025

What does this PR do?

Added additional fields to the GPUEntity in WMS

  • DriverVersion
  • TotalMemory (in mb)
  • MemoryBusWidth (in bits)
  • Max Clock Rate for SM and Memory

Motivation

Use WMS as the source for the hostgpu inventory payload (will come in a separate PR)

Describe how you validated your changes

Added those fields to the existing UT

Possible Drawbacks / Trade-offs

Additional Notes

@val06 val06 added changelog/no-changelog team/ebpf-platform qa/done QA done before merge and regressions are covered by tests labels Feb 25, 2025
@val06 val06 requested review from a team as code owners February 25, 2025 12:20
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 25, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2025

Uncompressed package size comparison

Comparison with ancestor 565c054734e9cc1f2ca02939feb6d99cf96047f4

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.02MB ⚠️ 845.45MB 845.43MB 0.50MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 845.45MB 845.43MB 0.50MB
datadog-agent-amd64-deb 0.01MB ⚠️ 835.66MB 835.64MB 0.50MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 835.94MB 835.93MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 826.17MB 826.16MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.28MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.03MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.10MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.10MB 62.09MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.34MB 59.33MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Feb 25, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a8839f9f-0921-4fb5-98b5-de925b37fa7a

Baseline: 565c054
Comparison: 16748a1
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.52 [-2.41, +3.46] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.60, +0.64] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.78, +0.81] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.62, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.03] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.83, +0.81] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.28, +0.25] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.83, +0.79] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.81, +0.74] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.07 [-0.54, +0.39] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.08 [-0.95, +0.78] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.17 [-0.95, +0.61] 1 Logs
quality_gate_idle_all_features memory utilization -0.36 [-0.41, -0.30] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.39 [-0.42, -0.35] 1 Logs bounds checks dashboard
file_tree memory utilization -0.84 [-0.90, -0.78] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.22 [-1.29, -1.16] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57030969 --os-family=ubuntu

Note: This applies to commit 16748a1

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 808.69MiB 841.59MiB 195.25MiB 210.72MiB
static_quality_gate_agent_deb_arm64 799.65MiB 830.66MiB 177.11MiB 192.1MiB
static_quality_gate_agent_rpm_amd64 808.66MiB 841.52MiB 198.14MiB 214.52MiB
static_quality_gate_agent_rpm_arm64 799.67MiB 830.66MiB 178.78MiB 193.64MiB
static_quality_gate_agent_suse_amd64 808.63MiB 841.52MiB 198.14MiB 214.52MiB
static_quality_gate_agent_suse_arm64 799.61MiB 830.66MiB 178.78MiB 194.03MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 49.7MiB 9.78MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 36.27MiB 48.1MiB 8.48MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.84MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 893.09MiB 926.0MiB 298.8MiB 317.43MiB
static_quality_gate_docker_agent_arm64 907.31MiB 939.07MiB 284.51MiB 302.43MiB
static_quality_gate_docker_agent_jmx_amd64 1.07GiB 1.1GiB 373.9MiB 392.54MiB
static_quality_gate_docker_agent_jmx_arm64 1.07GiB 1.1GiB 355.6MiB 373.21MiB
static_quality_gate_docker_dogstatsd_amd64 45.81MiB 57.88MiB 17.28MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 44.45MiB 56.27MiB 16.16MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.96MiB 274.78MiB 106.36MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.93MiB 290.82MiB 101.18MiB 111.12MiB

Copy link
Contributor

@gjulianm gjulianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 25, 2025
Copy link
Contributor

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
juste a small comment, but I already approved it

moved driver version API outside of devices loop
@val06
Copy link
Contributor Author

val06 commented Feb 26, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 26, 2025

View all feedbacks in Devflow UI.
2025-02-26 13:09:51 UTC ℹ️ Start processing command /merge


2025-02-26 13:09:54 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.


2025-02-26 14:18:05 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 12347d6 into main Feb 26, 2025
320 checks passed
@dd-mergequeue dd-mergequeue bot deleted the valeri.pliskin/wms-gpuentity-more-fields branch February 26, 2025 14:18
@github-actions github-actions bot added this to the 7.65.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants