[clusteragent/autoscaling] Only activate local recommender when load store is activated

[jennchenn]

What does this PR do?

• Gates local recommendations behind load store activation
• Updates some local recommender tests to make them more consistent

Motivation

When load store metrics are not collected, we are unable to make local recommendations. This steps skips the local recommender setup if the required metrics are not available to avoid spam. This means that local recommendations are no longer enabled by default.

There was a flake in one of the local recommender tests where the recommendation timestamp was off by one second - the change to use testTime instead of time.Now() in all the tests should ensure this doesn't happen again.

Describe how you validated your changes

Check that the local recommender is only setup when DD_AUTOSCALING_FAILOVER_ENABLED=true

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57080738 --os-family=ubuntu

Note: This applies to commit dccc968

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 57080738 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor e3dc9b4580ef0d221a536a0fde89d39203ccf02f

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	818.00MB	818.00MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	827.79MB	827.79MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	827.79MB	827.79MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	808.97MB	808.97MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	818.74MB	818.74MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.96MB	37.96MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	443.42MB	443.42MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.05MB	62.05MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.12MB	62.12MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.12MB	62.12MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.29MB	59.29MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.36MB	59.36MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	791.84MiB	801.8MiB	192.67MiB	202.62MiB
✅	static_quality_gate_agent_deb_arm64	783.22MiB	793.14MiB	175.61MiB	184.51MiB
✅	static_quality_gate_agent_rpm_amd64	791.92MiB	801.79MiB	195.02MiB	205.03MiB
✅	static_quality_gate_agent_rpm_arm64	783.17MiB	793.09MiB	176.41MiB	186.44MiB
✅	static_quality_gate_agent_suse_amd64	791.92MiB	801.81MiB	195.02MiB	205.03MiB
✅	static_quality_gate_agent_suse_arm64	783.27MiB	793.14MiB	176.41MiB	186.44MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	47.67MiB	9.78MiB	19.78MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.28MiB	46.27MiB	8.48MiB	18.49MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.25MiB	69.0MiB	14.89MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.62MiB	66.4MiB	12.83MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.25MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.62MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.25MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	876.25MiB	886.12MiB	294.27MiB	304.21MiB
✅	static_quality_gate_docker_agent_arm64	890.9MiB	900.79MiB	280.52MiB	290.47MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.06GiB	369.36MiB	379.33MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.06GiB	351.59MiB	361.55MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.82MiB	55.78MiB	17.28MiB	27.28MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	54.45MiB	16.16MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.96MiB	274.78MiB	106.35MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.92MiB	290.82MiB	101.18MiB	111.12MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: eb989413-9078-4a5f-99a8-87f218271dde

Baseline: e3dc9b4
Comparison: dccc968
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.59	[-2.36, +3.53]	1	Logs
➖	file_tree	memory utilization	+0.36	[+0.30, +0.42]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.30	[+0.25, +0.36]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.20	[-0.57, +0.98]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.10	[-0.68, +0.87]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.05	[-0.79, +0.88]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.25, +0.30]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.82, +0.84]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.60, +0.61]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.00	[-0.82, +0.81]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.04, +0.01]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.02	[-0.65, +0.61]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.04	[-0.51, +0.42]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.11	[-0.15, -0.07]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.66	[-0.71, -0.61]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.57	[-2.47, -0.67]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[vboulineau]

Needs to be backported as well

[jennchenn]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.
2025-02-26 16:22:49 UTC ℹ️ Start processing command /merge

---

2025-02-26 16:22:56 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

---

2025-02-26 16:23:11 UTC ❌ MergeQueue: This merge request is not mergeable, blocked by github

PR can't be merged according to github policy

[jennchenn]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.
2025-02-26 16:43:33 UTC ℹ️ Start processing command /merge

---

2025-02-26 16:43:37 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2025-02-26 17:33:09 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 29m.

---

2025-02-26 18:02:22 UTC ℹ️ MergeQueue: This merge request was merged