Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-apply "use github.com/mattn/go-sqlite3 instead of modernc for trivy" #34472

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Re-apply "use github.com/mattn/go-sqlite3 instead of modernc for trivy" #34472

merged 2 commits into from
Feb 26, 2025

Conversation

paulcacheux
Copy link
Contributor

Reverts #34468

@github-actions github-actions bot added team/agent-security medium review PR review might take time labels Feb 26, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Go Package Import Differences

Baseline: c714131
Comparison: 54207d2

binaryosarchchange
agentlinuxamd64
+0, -8 
-github.com/remyoudompheng/bigfft
-modernc.org/libc
-modernc.org/libc/sys/types
-modernc.org/libc/uuid/uuid
-modernc.org/mathutil
-modernc.org/memory
-modernc.org/sqlite
-modernc.org/sqlite/lib
agentlinuxarm64
+0, -8 
-github.com/remyoudompheng/bigfft
-modernc.org/libc
-modernc.org/libc/sys/types
-modernc.org/libc/uuid/uuid
-modernc.org/mathutil
-modernc.org/memory
-modernc.org/sqlite
-modernc.org/sqlite/lib
system-probelinuxamd64
+1, -8 
+github.com/mattn/go-sqlite3
-github.com/remyoudompheng/bigfft
-modernc.org/libc
-modernc.org/libc/sys/types
-modernc.org/libc/uuid/uuid
-modernc.org/mathutil
-modernc.org/memory
-modernc.org/sqlite
-modernc.org/sqlite/lib
system-probelinuxarm64
+1, -8 
+github.com/mattn/go-sqlite3
-github.com/remyoudompheng/bigfft
-modernc.org/libc
-modernc.org/libc/sys/types
-modernc.org/libc/uuid/uuid
-modernc.org/mathutil
-modernc.org/memory
-modernc.org/sqlite
-modernc.org/sqlite/lib

@paulcacheux paulcacheux added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Feb 26, 2025
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57038960 --os-family=ubuntu

Note: This applies to commit 54207d2

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor c714131b8c1ae684dd2a10498b2d7de5b9d351d2

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB ✅ 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 37.96MB 37.96MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.04MB 62.04MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.11MB 62.11MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.10MB 62.10MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.34MB 59.34MB 0.50MB
datadog-heroku-agent-amd64-deb -0.01MB ✅ 443.38MB 443.39MB 0.50MB
datadog-agent-aarch64-rpm -5.00MB ✅ 818.72MB 823.72MB 0.50MB
datadog-agent-arm64-deb -5.00MB ✅ 808.95MB 813.95MB 0.50MB
datadog-agent-amd64-deb -5.47MB ✅ 817.98MB 823.45MB 0.50MB
datadog-agent-x86_64-rpm -5.47MB ✅ 827.77MB 833.25MB 0.50MB
datadog-agent-x86_64-suse -5.47MB ✅ 827.77MB 833.25MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 791.9MiB 801.8MiB 192.65MiB 202.62MiB
✅ static_quality_gate_agent_deb_arm64 783.15MiB 793.14MiB 174.4MiB 184.51MiB
✅ static_quality_gate_agent_rpm_amd64 791.8MiB 801.79MiB 195.07MiB 205.03MiB
✅ static_quality_gate_agent_rpm_arm64 783.25MiB 793.09MiB 176.44MiB 186.44MiB
✅ static_quality_gate_agent_suse_amd64 791.76MiB 801.81MiB 195.07MiB 205.03MiB
✅ static_quality_gate_agent_suse_arm64 783.14MiB 793.14MiB 176.44MiB 186.44MiB
✅ static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.67MiB 9.78MiB 19.78MiB
✅ static_quality_gate_dogstatsd_deb_arm64 36.28MiB 46.27MiB 8.49MiB 18.49MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
✅ static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
✅ static_quality_gate_iot_agent_deb_amd64 59.24MiB 69.0MiB 14.89MiB 24.8MiB
✅ static_quality_gate_iot_agent_deb_arm64 56.6MiB 66.4MiB 12.82MiB 22.8MiB
✅ static_quality_gate_iot_agent_rpm_amd64 59.24MiB 69.0MiB 14.9MiB 24.8MiB
✅ static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
✅ static_quality_gate_iot_agent_suse_amd64 59.24MiB 69.0MiB 14.9MiB 24.8MiB
✅ static_quality_gate_docker_agent_amd64 876.23MiB 886.12MiB 294.24MiB 304.21MiB
✅ static_quality_gate_docker_agent_arm64 890.88MiB 900.79MiB 280.52MiB 290.47MiB
✅ static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.34MiB 379.33MiB
✅ static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.58MiB 361.55MiB
✅ static_quality_gate_docker_dogstatsd_amd64 45.82MiB 55.78MiB 17.28MiB 27.28MiB
✅ static_quality_gate_docker_dogstatsd_arm64 44.45MiB 54.45MiB 16.16MiB 26.16MiB
✅ static_quality_gate_docker_cluster_agent_amd64 264.95MiB 274.78MiB 106.36MiB 116.28MiB
✅ static_quality_gate_docker_cluster_agent_arm64 280.91MiB 290.82MiB 101.19MiB 111.12MiB

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2cbd3e3a-1830-48ba-a55c-20f7c0fb5080

Baseline: c714131
Comparison: 54207d2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +1.92 [-1.03, +4.86] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +1.25 [+0.38, +2.12] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.28 [+0.22, +0.34] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.12 [-0.66, +0.90] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.02 [-0.61, +0.64] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.02 [-0.28, +0.31] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.02 [-0.67, +0.70] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.84, +0.86] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.76, +0.78] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.80, +0.81] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.82, +0.79] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.52, +0.42] 1 Logs
➖ quality_gate_idle memory utilization -0.52 [-0.57, -0.47] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -1.09 [-1.14, -1.04] 1 Logs bounds checks dashboard
➖ file_tree memory utilization -1.10 [-1.16, -1.04] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux paulcacheux marked this pull request as ready for review February 26, 2025 14:11
@paulcacheux paulcacheux requested review from a team as code owners February 26, 2025 14:11
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 26, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-26 14:38:39 UTC ℹ️ Start processing command /merge

2025-02-26 14:38:43 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

2025-02-26 15:11:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit ef3c437 into main Feb 26, 2025
266 of 274 checks passed
@dd-mergequeue dd-mergequeue bot deleted the revert-34468-revert-34363-paulcacheux/sqlite-backend-trivy branch February 26, 2025 15:11
@github-actions github-actions bot added this to the 7.65.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spikat spikat spikat approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Milestone
7.65.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcacheux @spikat