[Dynamic Instrumentation] DI proctracker should not inspect itself

[tylfin]

What does this PR do?

This pull request includes changes to the pkg/dynamicinstrumentation/proctracker package to prevent self-inspection of the process and to add a corresponding test. The most important changes include adding a check to avoid self-inspection and creating a test to ensure the process is not added to the tracker.

Motivation

Go DI is still underdevelopment, and is currently only enabled when (1) the DD_DYNAMIC_INSTRUMENTATION_ENABLED environment variable is set, and (2) there are Go applications running in the environment.

When we enable DI for another language, e.g. Python, by setting the DD_DYNAMIC_INSTRUMENTATION_ENABLED, then Go DI will always instrument itself because of the system-probe itself.

Describe how you validated your changes

• pkg/dynamicinstrumentation/proctracker/proctracker_test.go: Added a new test TestProcessNotAdded to verify that the current process ID is not added to the processes map in the ProcessTracker.

Possible Drawbacks / Trade-offs

Additional Notes

[bits-bot]

All committers have signed the CLA.

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor c714131b8c1ae684dd2a10498b2d7de5b9d351d2

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	823.45MB	823.45MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	833.25MB	833.25MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	833.25MB	833.25MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	813.95MB	813.95MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	823.72MB	823.72MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.96MB	37.96MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	443.39MB	443.39MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.04MB	62.04MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.11MB	62.11MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.10MB	62.10MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.27MB	59.27MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.34MB	59.34MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 57114092 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57114092 --os-family=ubuntu

Note: This applies to commit 75d0849

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	797.01MiB	801.8MiB	194.72MiB	202.62MiB
✅	static_quality_gate_agent_deb_arm64	787.99MiB	793.14MiB	176.46MiB	184.51MiB
✅	static_quality_gate_agent_rpm_amd64	797.1MiB	801.79MiB	196.64MiB	205.03MiB
✅	static_quality_gate_agent_rpm_arm64	787.91MiB	793.09MiB	178.42MiB	186.44MiB
✅	static_quality_gate_agent_suse_amd64	796.98MiB	801.81MiB	196.64MiB	205.03MiB
✅	static_quality_gate_agent_suse_arm64	787.92MiB	793.14MiB	178.42MiB	186.44MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	47.67MiB	9.78MiB	19.78MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.28MiB	46.27MiB	8.49MiB	18.49MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.24MiB	69.0MiB	14.88MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.6MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.24MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.6MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.24MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	881.45MiB	886.12MiB	296.73MiB	304.21MiB
✅	static_quality_gate_docker_agent_arm64	895.65MiB	900.79MiB	282.74MiB	290.47MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.06GiB	371.84MiB	379.33MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.06GiB	1.06GiB	353.84MiB	361.55MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.82MiB	55.78MiB	17.28MiB	27.28MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	54.45MiB	16.16MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.95MiB	274.78MiB	106.36MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.91MiB	290.82MiB	101.19MiB	111.12MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9986cc9b-394f-49fc-bea3-c70d4c676c03

Baseline: c714131
Comparison: 75d0849
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+0.65	[+0.59, +0.72]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.37	[+0.31, +0.42]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.04	[-0.82, +0.91]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.04	[-0.73, +0.82]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.27, +0.30]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.02	[-0.45, +0.48]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.01	[-0.61, +0.64]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.74, +0.76]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.78, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.81, +0.81]	1	Logs
➖	quality_gate_idle	memory utilization	+0.00	[-0.04, +0.04]	1	Logs bounds checks dashboard
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.62, +0.61]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.05	[-0.88, +0.79]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.24	[-3.14, +2.66]	1	Logs
➖	file_tree	memory utilization	-0.57	[-0.62, -0.51]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[grantseltzer]

LGTM

[tylfin]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.
2025-02-26 21:43:21 UTC ℹ️ Start processing command /merge

---

2025-02-26 21:43:23 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

---

2025-02-26 22:11:33 UTC ℹ️ MergeQueue: This merge request was merged