[do not merge] Test better struct alignment to see smp performance benchmarks #34497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/system-probe
long review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some brief analysis confirmed we were not doing any struct packing / alignment and reordering the fields could make structs more compact. Go does byte padding within a struct for alignment purposes and reordering could remove unnecessary padding.
This draft PR is just to test if there is any significant performance return. Initial calculations from the static analysis suggested 16KB across the code base but depending on which structs and how many are initialized we may see more than that.
Motivation
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes