Run gopls modernize tool

[pgimalac]

What does this PR do?

Run https://github.com/golang/tools/blob/master/gopls/internal/analysis/modernize/cmd/modernize/main.go on the codebase.
I disabled some rules manually (eg. replacing all interface{} by any) to only keep the interesting ones and limit noise.

The remaining changes are pretty much just using slices, maps, min, and max, instead of reimplementing ourself.

Motivation

When some function is added to the standard library, we might as well use it rather than re-implement it ourself.
Maybe some binary size reduction.

Describe how you validated your changes

There should be no functional change.
CI is enough.

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor da8f45d6caa48e25d25097fd7600acdae4a749db

Diff per package

package	diff	status	size	ancestor	threshold
datadog-heroku-agent-amd64-deb	0.02MB	⚠️	443.44MB	443.42MB	0.50MB
datadog-agent-arm64-deb	0.02MB	⚠️	808.99MB	808.97MB	0.50MB
datadog-agent-aarch64-rpm	0.02MB	⚠️	818.77MB	818.75MB	0.50MB
datadog-agent-amd64-deb	0.02MB	⚠️	818.02MB	818.00MB	0.50MB
datadog-agent-x86_64-rpm	0.02MB	⚠️	827.81MB	827.80MB	0.50MB
datadog-agent-x86_64-suse	0.02MB	⚠️	827.81MB	827.80MB	0.50MB
datadog-iot-agent-arm64-deb	0.02MB	⚠️	59.30MB	59.29MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.02MB	⚠️	59.37MB	59.36MB	0.50MB
datadog-iot-agent-amd64-deb	0.01MB	⚠️	62.06MB	62.05MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.01MB	⚠️	62.13MB	62.12MB	0.50MB
datadog-iot-agent-x86_64-suse	0.01MB	⚠️	62.13MB	62.12MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.97MB	37.96MB	0.50MB

Decision

⚠️ Warning

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57144899 --os-family=ubuntu

Note: This applies to commit 46c3240

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	791.93MiB	801.8MiB	192.62MiB	202.62MiB
✅	static_quality_gate_agent_deb_arm64	783.19MiB	793.14MiB	174.54MiB	184.51MiB
✅	static_quality_gate_agent_rpm_amd64	791.81MiB	801.79MiB	195.0MiB	205.03MiB
✅	static_quality_gate_agent_rpm_arm64	783.27MiB	793.09MiB	176.38MiB	186.44MiB
✅	static_quality_gate_agent_suse_amd64	791.93MiB	801.81MiB	195.0MiB	205.03MiB
✅	static_quality_gate_agent_suse_arm64	783.15MiB	793.14MiB	176.38MiB	186.44MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	47.67MiB	9.78MiB	19.78MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.28MiB	46.27MiB	8.49MiB	18.49MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.27MiB	69.0MiB	14.89MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.63MiB	66.4MiB	12.86MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.27MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.63MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.27MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	876.27MiB	886.12MiB	294.27MiB	304.21MiB
✅	static_quality_gate_docker_agent_arm64	890.93MiB	900.79MiB	280.52MiB	290.47MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.06GiB	369.35MiB	379.33MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.06GiB	351.59MiB	361.55MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.82MiB	55.78MiB	17.28MiB	27.28MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.47MiB	54.45MiB	16.16MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.98MiB	274.78MiB	106.38MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.95MiB	290.82MiB	101.2MiB	111.12MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3f21806e-2ec5-482c-b8a1-23469dc6d24b

Baseline: da8f45d
Comparison: 46c3240
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.24	[+1.35, +3.13]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.98	[-1.90, +3.87]	1	Logs
➖	quality_gate_idle	memory utilization	+0.54	[+0.51, +0.57]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.33	[+0.27, +0.39]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.06	[-0.40, +0.53]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.05	[-0.74, +0.84]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.03	[-0.82, +0.87]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.81, +0.84]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.28, +0.30]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.00	[-0.84, +0.85]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.68, +0.68]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.00	[-0.63, +0.64]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.03, +0.03]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.08	[-0.86, +0.70]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.19	[-0.24, -0.15]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.48	[-0.54, -0.42]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.