Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws-sdk v3 for secrets manager #616

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Use aws-sdk v3 for secrets manager #616

merged 3 commits into from
Feb 5, 2025

Conversation

DylanLovesCoffee
Copy link
Contributor

What does this PR do?

Uses aws-sdk v3 for accessing secrets manager. V2 will hit EOL :(

Motivation

#615

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DylanLovesCoffee DylanLovesCoffee requested a review from a team as a code owner February 5, 2025 02:20
package.json Outdated
@@ -21,6 +21,7 @@
},
"devDependencies": {
"@aws-sdk/client-kms": "^3.366.0",
"@aws-sdk/client-secrets-manager": "^3.741.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pin it to a compatible version with node 16?

@DylanLovesCoffee
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 14:58:10 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 0s.


2025-02-05 15:10:52 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 4724a63 into main Feb 5, 2025
31 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dylan/aws-sdk-v3 branch February 5, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants