Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-remove iast .so file. #560

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Re-remove iast .so file. #560

wants to merge 2 commits into from

Conversation

purple4reina
Copy link
Contributor

Commit DataDog/dd-trace-py@fa18def was merged to address this.

What does this PR do?

Re-removes the ddtrace/appsec/_iast/_stacktrace*.so file from our python layers.

Motivation

A change was made by the appsec team to the python tracer which inadvertently caused an import attempt on ddtrace/appsec/_iast/_stacktrace*.so. This import would fail when using our python layer. We remove this file because it is large and iast doesn't work in serverless anyway.

I worked with the appsec team directly to address this. They came up with a solution that not only ensures we don't import ddtrace/appsec/_iast/_stacktrace*.so, but also makes sure no iast code is imported when iast is disabled.

Now that DataDog/dd-trace-py#12212 is merged, we can go back to safely removing this .so file in our layers.

Testing Guidelines

I have another PR open to the python agent (DataDog/dd-trace-py#11888) which will add explicit testing to ensure none of our removed files get imported.

Additional Notes

Note that the mentioned PR is merged but not yet released! Do not merge this until that PR has been released!

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

Commit DataDog/dd-trace-py@fa18def
was merged to address this.
@purple4reina purple4reina requested a review from a team as a code owner February 14, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant