From 7383f63796281a2e2d11d0f55699d063cf244481 Mon Sep 17 00:00:00 2001 From: Sergio Barrio Date: Wed, 16 Jul 2025 12:03:28 +0200 Subject: [PATCH] Add setIsNewArchitecture testOnly function to ensure sessionStartedListener tests enforce old arch --- .../com/datadog/reactnative/DdSdkSessionStartedListener.kt | 5 +++++ .../datadog/reactnative/DdSdkSessionStartedListenerTest.kt | 2 ++ 2 files changed, 7 insertions(+) diff --git a/packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkSessionStartedListener.kt b/packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkSessionStartedListener.kt index 9e75aae4d..92a9467f3 100644 --- a/packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkSessionStartedListener.kt +++ b/packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkSessionStartedListener.kt @@ -60,6 +60,11 @@ internal class DdSdkSessionStartedListener private constructor(): RumSessionList this.exceptionHandler = exceptionHandler } + @TestOnly + fun setIsNewArchitecture(isNewArch: Boolean) { + this.isNewArchitecture = isNewArch + } + private fun hasValidBridge(): Boolean { val context = reactContext ?: return false val instance = context.catalystInstance ?: return false diff --git a/packages/core/android/src/test/kotlin/com/datadog/reactnative/DdSdkSessionStartedListenerTest.kt b/packages/core/android/src/test/kotlin/com/datadog/reactnative/DdSdkSessionStartedListenerTest.kt index 8aae270c0..e5007748e 100644 --- a/packages/core/android/src/test/kotlin/com/datadog/reactnative/DdSdkSessionStartedListenerTest.kt +++ b/packages/core/android/src/test/kotlin/com/datadog/reactnative/DdSdkSessionStartedListenerTest.kt @@ -90,6 +90,7 @@ internal class DdSdkSessionStartedListenerTest { val instance = DdSdkSessionStartedListener.getInstance() instance.setReactContext(mockReactContext) instance.setExceptionHandler(mockExceptionHandler) + instance.setIsNewArchitecture(false) val passedArgs = mutableListOf() instance.setConvertToNativeArray { @@ -124,6 +125,7 @@ internal class DdSdkSessionStartedListenerTest { val mockConvertToNativeArray = mock<(array: Array) -> NativeArray?>() instance.setConvertToNativeArray(mockConvertToNativeArray) + instance.setIsNewArchitecture(false) // WHEN instance.onSessionStarted("TEST-SESSION-ID", false)