-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add telemetry logs #185
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 93.60% 93.16% -0.45%
==========================================
Files 73 73
Lines 4256 4286 +30
==========================================
+ Hits 3984 3993 +9
- Misses 272 293 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Don't we want to add a test for logs payload as well ? Maybe you want to do it after the refactoring. I could get that.
class Telemetry { | ||
/// The telemetry class is responsible for handling internal telemetry data to | ||
/// track Datadog product usage. It _can_ collect and report logs and metrics. | ||
/// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have private headers ? If yes, is there a reason to put the file in the public headers and say do not use ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imagine I am implementing appsec, how Datadog user/integrator outside of the tracer could use it if it's private?
Description
Add support telemetry logs
Note to reviewers
This PR only adds the API for collecting and reporting logs. As of now, the library is not yet reporting logs because I am planning to refactor the whole telemetry module and error handling.