Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): Handle empty configuration payload properly #186

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

dmehala
Copy link
Collaborator

@dmehala dmehala commented Feb 11, 2025

Description

This fix addresses two issues:

  1. Prevents invalid telemetry payloads when there are no configuration entries.
  2. Ensures configuration updates are correctly processed and not carried over to the next update.

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

This fix addresses two issues:
1. Prevents invalid telemetry payloads when there are no
configuration entries.
2. Ensures configuration updates are correctly processed
and not carried over to the next update.
@dmehala dmehala requested a review from a team as a code owner February 11, 2025 21:24
@dmehala dmehala requested review from pablomartinezbernardo and removed request for a team February 11, 2025 21:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.78%. Comparing base (ccbbae9) to head (1d16fca).

Files with missing lines Patch % Lines
src/datadog/datadog_agent.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   93.80%   93.78%   -0.02%     
==========================================
  Files          73       73              
  Lines        4195     4199       +4     
==========================================
+ Hits         3935     3938       +3     
- Misses        260      261       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmehala dmehala merged commit 62a9e91 into main Feb 14, 2025
21 checks passed
@dmehala dmehala deleted the dmehala/fix-invalid-payload branch February 14, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants