Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(msvc): fix compilation warnings #188

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

dmehala
Copy link
Collaborator

@dmehala dmehala commented Feb 15, 2025

Description

Fix warnings.

Changes:

  • Treat warnings as error in CI builds for MSVC.

Changes:
  - Treat warnings as error in CI builds for MSVC.
@dmehala dmehala requested a review from a team as a code owner February 15, 2025 18:20
@dmehala dmehala requested review from Anilm3, zacharycmontoya and pablomartinezbernardo and removed request for a team February 15, 2025 18:20
@pr-commenter
Copy link

pr-commenter bot commented Feb 18, 2025

Benchmarks

Benchmark execution time: 2025-02-18 19:15:36

Comparing candidate commit a3366d0 in PR branch dmehala/fix-msvc-warnings with baseline commit f3ebccc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (f3ebccc) to head (a3366d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          73       73           
  Lines        4256     4256           
=======================================
  Hits         3984     3984           
  Misses        272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmehala dmehala merged commit dc5781d into main Feb 18, 2025
21 checks passed
@dmehala dmehala deleted the dmehala/fix-msvc-warnings branch February 18, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants