Apply suggestions from code review

andrewlock · web-flow · commit 5ae4054bcb56 · 2025-12-01T16:53:53.000+01:00
diff --git a/tracer/src/Datadog.Trace/Agent/MessagePack/TraceChunkModel.cs b/tracer/src/Datadog.Trace/Agent/MessagePack/TraceChunkModel.cs
@@ -239,7 +239,7 @@ private bool Contains(ulong spanId, int startIndex)
     }
 
     /// <summary>
-    /// Searches for the specified spanId by iteration the array of spans.
+    /// Searches for the specified spanId by iterating the array of spans.
     /// </summary>
     private int IndexOf(ulong spanId, int startIndex)
     {
diff --git a/tracer/src/Datadog.Trace/Span.cs b/tracer/src/Datadog.Trace/Span.cs
@@ -47,7 +47,7 @@ internal Span(SpanContext context, DateTimeOffset? start, ITags tags, IEnumerabl
 
             if (links is not null)
             {
-                // We know we're not finished and this allows optimizations vs using AddLink()
+                // We're in the constructor, so doing a direct replace allows optimizations vs using AddLink()
                 SpanLinks = [..links];
             }
 

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ private bool Contains(ulong spanId, int startIndex)`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`/// <summary>`
`242`		`- /// Searches for the specified spanId by iteration the array of spans.`
	`242`	`+ /// Searches for the specified spanId by iterating the array of spans.`
`243`	`243`	`/// </summary>`
`244`	`244`	`private int IndexOf(ulong spanId, int startIndex)`
`245`	`245`	`{`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ internal Span(SpanContext context, DateTimeOffset? start, ITags tags, IEnumerabl`
`47`	`47`
`48`	`48`	`if (links is not null)`
`49`	`49`	`{`
`50`		`- // We know we're not finished and this allows optimizations vs using AddLink()`
	`50`	`+ // We're in the constructor, so doing a direct replace allows optimizations vs using AddLink()`
`51`	`51`	`SpanLinks = [..links];`
`52`	`52`	`}`
`53`	`53`