system-tests passes

Signed-off-by: Eliott Bouhana <[email protected]>

Author: eliottness

openfeature/evaluator.go

@@ -92,7 +92,8 @@ func evaluateAllocation(allocation *allocation, context map[string]any, currentT
 	}
 
 	// Check if any rule matches (OR logic between rules)
-	ruleMatched := false
+	// If there are no rules, the allocation matches everyone
+	ruleMatched := len(allocation.Rules) == 0
 	for _, rule := range allocation.Rules {
 		if evaluateRule(rule, context) {
 			ruleMatched = true
@@ -128,6 +129,14 @@ func evaluateRule(rule *rule, context map[string]any) bool {
 func evaluateCondition(condition *condition, context map[string]any) bool {
 	attributeValue, exists := context[condition.Attribute]
 
+	// Special handling for "id" attribute: if not explicitly provided, use targeting key
+	if condition.Attribute == "id" && !exists {
+		if targetingKey, ok := context[of.TargetingKey].(string); ok {
+			attributeValue = targetingKey
+			exists = true
+		}
+	}
+
 	// Special handling for IS_NULL operator
 	if condition.Operator == operatorIsNull {
 		isNull := !exists || attributeValue == nil
@@ -339,7 +348,7 @@ func evaluateShard(shard *shard, context map[string]any) bool {
 // computeShardIndex computes the shard index using MD5 hash.
 // This matches the Eppo SDK implementation for consistent behavior.
 func computeShardIndex(salt, targetingKey string, totalShards int) int {
-	input := salt + targetingKey
+	input := salt + "-" + targetingKey
 	hash := md5.Sum([]byte(input))
 	// Use first 4 bytes of MD5 hash as uint32
 	intVal := binary.BigEndian.Uint32(hash[:4])