Skip to content

Commit c38b0f2

Browse files
committed
Update comment
1 parent 9d1b892 commit c38b0f2

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,9 @@ public final class ConfigDefaults {
105105

106106
public static final boolean DEFAULT_METRICS_OTEL_ENABLED = false;
107107
static final Exporter DEFAULT_OTEL_METRICS_EXPORTER = Exporter.OTLP;
108-
// WARNING: This defies the OpenTelemetry specification’s default value of 60000 (60s)
108+
// Default recommended by Datadog; it differs from Otel’s default of 60000 (60s)
109109
static final Integer DEFAULT_OTEL_METRIC_EXPORT_INTERVAL = 10000;
110-
// WARNING: This defies the OpenTelemetry specification’s default value of 30000 (30s)
110+
// Default recommended by Datadog; it differs from Otel’s default of 30000 (30s)
111111
static final Integer DEFAULT_OTEL_METRIC_EXPORT_TIMEOUT = 7500;
112112
static final String DEFAULT_OTEL_METRIC_ENDPOINT_SUFFIX = "v1/metrics";
113113
static final String DEFAULT_OTEL_METRIC_ENDPOINT_HTTP_PORT = "4318";

internal-api/src/main/java/datadog/trace/api/Config.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1914,9 +1914,7 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
19141914
"_");
19151915
}
19161916
otelExporterOtlpMetricsProtocol = tmpOtelExporterOtlpMetricsProtocol;
1917-
// TO DO
1918-
// Add some error log and switch the protocol to the default value if we don't support the
1919-
// selected protocol
1917+
// TODO: log warning and switch protocol to default if we don't support the selected protocol?
19201918

19211919
String tmpOtelExporterOtlpMetricsEndpoint =
19221920
configProvider.getString(OTEL_EXPORTER_OTLP_METRICS_ENDPOINT);

0 commit comments

Comments
 (0)