Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(encoding): fix encoding errors when the span started a very long time ago #12368

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Feb 14, 2025

Possible cause behind #12240. If the span started a very long time ago, the encoding fails with:

raise RuntimeError("failed to pack span: {!r}. Exception: {}".format(span, e))
E RuntimeError: failed to pack span: <Span(id=2850960614187153438,trace_id=137823137092894037702114325005943826011,parent_id=None,name=None)>. Exception: Python int too large to convert to C long

TODO: Find a good way to check the min/max without causing issues.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

tests/tracer/test_encoders.py                                           @DataDog/apm-sdk-api-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: wantsui/span-start-time
Commit report: 0b22c45
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 1m 36.47s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 14, 2025

Benchmarks

Benchmark execution time: 2025-02-14 23:44:35

Comparing candidate commit 0b22c45 in PR branch wantsui/span-start-time with baseline commit a5e3552 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant