Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move boto suites to gitlab #12498

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Feb 24, 2025

depends on https://github.com/DataDog/images/pull/6664

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners February 24, 2025 20:57
@emmettbutler emmettbutler marked this pull request as draft February 24, 2025 20:57
Copy link
Contributor

github-actions bot commented Feb 24, 2025

CODEOWNERS have been resolved as:

.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab/services.yml                                                    @DataDog/python-guild @DataDog/apm-core-python
tests/contrib/aiobotocore/utils.py                                      @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python

@pr-commenter
Copy link

pr-commenter bot commented Feb 24, 2025

Benchmarks

Benchmark execution time: 2025-02-25 18:56:51

Comparing candidate commit dd569dd in PR branch emmett.butler/boto-gitlab with baseline commit f76498f in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 415 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+294.402ns; +360.024ns] or [+8.120%; +9.930%]

scenario:iast_aspects-ospathsplitdrive_aspect

  • 🟥 execution_time [+214.124ns; +248.164ns] or [+8.093%; +9.379%]

scenario:iast_aspects-split_aspect

  • 🟥 execution_time [+126.286ns; +154.172ns] or [+7.305%; +8.918%]

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant