Jonathan.chavez/llm experiments 2 #12500
Conversation
…dd-trace-py into jonathan.chavez/llm-experiments
…havez/llm-experiments
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| else: | ||
| return projects[0]["id"] |
There was a problem hiding this comment.
⚪ Code Quality Violation
else is not necessary since the if clause has a return (...read more)
If the code in the if branch returns a value, do not have the else branch present.
|
|
||
| # Clear previous line if needed | ||
| if self._last_len > len(status): | ||
| print("\r" + " " * self._last_len, end="") |
There was a problem hiding this comment.
🟠 Code Quality Violation
use f-string or .format to format strings (...read more)
Concatenation of multiple strings is not efficient and make the code hard to read and understand.
Instead of concatenating multiple strings, use an f-string or a format string.
Learn More
| if seconds < 60: | ||
| return f"{seconds:.1f}s" | ||
| minutes = int(seconds / 60) | ||
| seconds = seconds % 60 |
There was a problem hiding this comment.
🟠 Code Quality Violation
variable name is the same as a function parameter (...read more)
A function parameter should only be read and not be modified. If your intent is to modify the value of the parameter, return the value in the function and handle the new value in the caller of the function.
BenchmarksBenchmark execution time: 2025-02-25 21:04:28 Comparing candidate commit cbf4d2d in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 392 metrics, 2 unstable metrics. scenario:iast_aspects-ospathjoin_aspect
scenario:iast_aspects-ospathsplit_aspect
|
| kwargs: Dict[str, Any], | ||
| chat_completions: Any, | ||
| is_workflow: bool = False, | ||
| self, span: Span, args: List[Any], kwargs: Dict[str, Any], chat_completions: Any, is_workflow: bool = False |
There was a problem hiding this comment.
🟠 Code Quality Violation
do not use Any, use a concrete type (...read more)
Use the Any type very carefully. Most of the time, the Any type is used because we do not know exactly what type is being used. If you want to specify that a value can be of any type, use object instead of Any.
Learn More
jjxct
force-pushed
the
jonathan.chavez/llm-experiments-2
branch
from
6563434 to
cbf4d2d
Compare
Checklist
Reviewer Checklist