Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add notification channel for build pipeline [backport 2.19] #12511

Open
wants to merge 1 commit into
base: 2.19
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Backport 34e6b84 from #12426 to 2.19.

This PR adds a channel for notifications.

One-pipeline added notification messages for failed releases. More notifications may be added in the future

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This PR adds a channel for notifications.

One-pipeline added notification messages for failed releases. More
notifications may be added in the future

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 34e6b84)
@github-actions github-actions bot requested a review from a team as a code owner February 25, 2025 16:30
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. CI labels Feb 25, 2025
@github-actions github-actions bot requested a review from juanjux February 25, 2025 16:30
@pr-commenter
Copy link

pr-commenter bot commented Feb 25, 2025

Benchmarks

Benchmark execution time: 2025-02-25 17:11:56

Comparing candidate commit 96cd7c1 in PR branch backport-12426-to-2.19 with baseline commit dd4f3b5 in branch 2.19.

Found 2 performance improvements and 2 performance regressions! Performance is the same for 390 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟩 execution_time [-616.244ns; -551.621ns] or [-14.555%; -13.029%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+366.601ns; +435.104ns] or [+7.150%; +8.486%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟩 execution_time [-535.702ns; -472.382ns] or [-12.240%; -10.794%]

scenario:iast_aspects-splitlines_aspect

  • 🟥 execution_time [+144.951ns; +175.999ns] or [+8.480%; +10.296%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants