Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move aws_lambda, datastreams, and opentelemetry suites to gitlab #12518

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Feb 25, 2025

This change moves to gitlab the aws_lambda, datastreams, and opentelemetry test suites as part of the ongoing migration from circleci.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners February 25, 2025 19:57
@emmettbutler emmettbutler marked this pull request as draft February 25, 2025 19:57
Copy link
Contributor

github-actions bot commented Feb 25, 2025

CODEOWNERS have been resolved as:

.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab/services.yml                                                    @DataDog/python-guild @DataDog/apm-core-python
tests/opentelemetry/test_context.py                                     @DataDog/apm-sdk-api-python
tests/opentelemetry/test_trace.py                                       @DataDog/apm-sdk-api-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 25, 2025

Datadog Report

Branch report: emmett.butler/lambda-datastreams-otel
Commit report: 553938f
Test service: dd-trace-py

✅ 0 Failed, 43 Passed, 215 Skipped, 46.36s Total duration (6m 9.46s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 25, 2025

Benchmarks

Benchmark execution time: 2025-02-26 20:19:28

Comparing candidate commit 553938f in PR branch emmett.butler/lambda-datastreams-otel with baseline commit 2aa4ffb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 404 metrics, 2 unstable metrics.

@emmettbutler emmettbutler marked this pull request as ready for review February 26, 2025 19:13
@emmettbutler emmettbutler requested a review from a team as a code owner February 26, 2025 19:13
@emmettbutler emmettbutler changed the title move aws_lambda, datastreams, and opentelemetry suites to gitlab ci: move aws_lambda, datastreams, and opentelemetry suites to gitlab Feb 26, 2025
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 26, 2025
@emmettbutler emmettbutler enabled auto-merge (squash) February 26, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant