Integration/jonathan.chavez/llm experiments 2

[jjxct]

Checklist

• PR author has checked that all the criteria below are met
• The PR description includes an overview of the change
• The PR description articulates the motivation for the change
• The change includes tests OR the PR description describes a testing strategy
• The PR description notes risks associated with the change, if any
• Newly-added code is easy to change
• The change follows the library release note guidelines
• The change includes or references documentation updates if necessary
• Backport labels are set (if applicable)

Reviewer Checklist

• Reviewer has checked that all the criteria below are met
• Title is accurate
• All changes are related to the pull request's stated goal
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Newly-added code is easy to change
• Release note makes sense to a user of the library
• If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[github-actions]

CODEOWNERS have been resolved as:

ddtrace/llmobs/experimentation/__init__.py                              @DataDog/ml-observability
ddtrace/llmobs/experimentation/_experiments.py                          @DataDog/ml-observability
tests/llmobs/cassettes/experiments/test_dataset_pull.yaml               @DataDog/ml-observability
tests/llmobs/cassettes/experiments/test_dataset_pull_dne.yaml           @DataDog/ml-observability
tests/llmobs/test_llmobs_experiments.py                                 @DataDog/ml-observability
ddtrace/llmobs/__init__.py                                              @DataDog/ml-observability
ddtrace/llmobs/_constants.py                                            @DataDog/ml-observability
ddtrace/llmobs/_integrations/base.py                                    @DataDog/ml-observability
ddtrace/llmobs/_llmobs.py                                               @DataDog/ml-observability
ddtrace/llmobs/_utils.py                                                @DataDog/ml-observability
ddtrace/llmobs/_writer.py                                               @DataDog/ml-observability
tests/llmobs/test_utils.py                                              @DataDog/ml-observability

[datadog-datadog-prod-us1]

⚪ Code Quality Violation

else is not necessary since the if clause has a return (...read more)

If the code in the if branch returns a value, do not have the else branch present.

    

[datadog-datadog-prod-us1]

🟠 Code Quality Violation

variable name is the same as a function parameter (...read more)

A function parameter should only be read and not be modified. If your intent is to modify the value of the parameter, return the value in the function and handle the new value in the caller of the function.

    

[datadog-datadog-prod-us1]

🟠 Code Quality Violation

use f-string or .format to format strings (...read more)

Concatenation of multiple strings is not efficient and make the code hard to read and understand.

Instead of concatenating multiple strings, use an f-string or a format string.

Learn More

• Python Documentation: str.format()
• Python Documentation - f-string

    

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-02-25 21:13:02

Comparing candidate commit e17d8c8 in PR branch integration/jonathan.chavez/llm-experiments-2 with baseline commit b4f4f62 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 398 metrics, 0 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

• 🟩 execution_time [-394.521ns; -324.963ns] or [-9.738%; -8.021%]

scenario:iast_aspects-ospathjoin_aspect

• 🟩 execution_time [-476.858ns; -413.329ns] or [-8.608%; -7.461%]