Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move build_docs to gitlab #12531

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Feb 26, 2025

This change moves the build_docs CI job to gitlab as part of the ongoing migration away from circleci.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners February 26, 2025 18:40
@emmettbutler emmettbutler marked this pull request as draft February 26, 2025 18:40
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab-ci-local/.gitignore                                             @DataDog/apm-core-python
.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab/package.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
scripts/gen_circleci_config.py                                          @DataDog/apm-core-python
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 26, 2025

Datadog Report

Branch report: emmett.butler/gitlab-build-docs
Commit report: 1dff133
Test service: dd-trace-py

✅ 0 Failed, 43 Passed, 290 Skipped, 50.81s Total duration (5m 33.99s time saved)

@emmettbutler emmettbutler changed the title move build_docs to gitlab ci: move build_docs to gitlab Feb 26, 2025
@emmettbutler emmettbutler marked this pull request as ready for review February 26, 2025 19:41
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 26, 2025
@emmettbutler emmettbutler enabled auto-merge (squash) February 26, 2025 19:54
@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2025

Benchmarks

Benchmark execution time: 2025-02-26 21:07:32

Comparing candidate commit 1dff133 in PR branch emmett.butler/gitlab-build-docs with baseline commit 2aa4ffb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant