Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move promote-oci-to-prod job to release stage #12534

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Feb 26, 2025

We want to ensure that no artifacts are published anywhere until the very end of the release pipeline. This was true for our PyPI pubilshing, but not for OCI images. This change will make the OCI publish job dependent on no jobs, but part of the release stage to ensure this.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 26, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python

@erikayasuda erikayasuda marked this pull request as ready for review February 26, 2025 22:04
@erikayasuda erikayasuda requested a review from a team as a code owner February 26, 2025 22:04
@erikayasuda erikayasuda requested a review from juanjux February 26, 2025 22:04
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 26, 2025

Datadog Report

Branch report: erikayasuda/move-oci-job
Commit report: 961c5ec
Test service: dd-trace-py

✅ 0 Failed, 43 Passed, 290 Skipped, 50.59s Total duration (6m 27.02s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2025

Benchmarks

Benchmark execution time: 2025-02-26 23:02:52

Comparing candidate commit 507489c in PR branch erikayasuda/move-oci-job with baseline commit 2aa4ffb in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 402 metrics, 2 unstable metrics.

scenario:iast_aspects-format_map_aspect

  • 🟥 execution_time [+372.235ns; +428.425ns] or [+7.165%; +8.246%]

scenario:iast_aspects-rsplit_aspect

  • 🟥 execution_time [+128.732ns; +156.820ns] or [+7.384%; +8.995%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant