-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(envier): support multiple sources #12535
base: munir/bump-lib-datadog
Are you sure you want to change the base?
fix(envier): support multiple sources #12535
Conversation
|
set, | ||
"includes", | ||
default=set(), | ||
help_type="List", | ||
help="List of modules/packages to include in the symbol uploads", | ||
) | ||
_includes_re = En.d(re.Pattern, lambda c: re.compile("(" + "|".join(f"^{p}$|^{p}[.]" for p in c.includes) + ")")) | ||
_includes_re = EnvDD.d(re.Pattern, lambda c: re.compile("(" + "|".join(f"^{p}$|^{p}[.]" for p in c.includes) + ")")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Quality Violation
use f-string or .format to format strings (...read more)
Concatenation of multiple strings is not efficient and make the code hard to read and understand.
Instead of concatenating multiple strings, use an f-string or a format string.
Learn More
BenchmarksBenchmark execution time: 2025-02-26 23:35:32 Comparing candidate commit 748ab59 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics. |
Currently
envier.Env
supports reading environment variables from one source (usually os.enviorn). This PR introducesEnvDD
which will add support for loading environment variables from multiple sources.This will be used to load configurations from files and through the DatadogUI.
Note - This PR attempts to support multiple configuration sources without updating the envier library. This approach will be refactored when stable support configurations is GA 🤞.
Checklist
Reviewer Checklist