-
Notifications
You must be signed in to change notification settings - Fork 469
feat(aap): add redirect request support for api10 on urllib #15443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(aap): add redirect request support for api10 on urllib #15443
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 247 ± 3 ms. The average import time from base is: 249 ± 3 ms. The import time difference between this PR and base is: -2.2 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate christophe-papazian/api10_redirection_urllib (a2529a3) with baseline main (2590370) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5% Memory: ✅ 40.260MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.7% Memory: ✅ 40.348MB (SLO: <41.500MB -2.8%) vs baseline: +4.5% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.3% Memory: ✅ 40.266MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: ~same Memory: ✅ 40.269MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 1.354µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.1% Memory: ✅ 40.087MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ bytearray_extend_aspectTime: ✅ 1.504µs (SLO: <10.000µs 📉 -85.0%) vs baseline: +0.8% Memory: ✅ 40.371MB (SLO: <41.500MB -2.7%) vs baseline: +4.7% ✅ bytearray_extend_noaspectTime: ✅ 0.609µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.7% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.1% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.9% Memory: ✅ 40.228MB (SLO: <41.500MB -3.1%) vs baseline: +4.0% ✅ bytes_aspectTime: ✅ 1.276µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +0.2% Memory: ✅ 40.301MB (SLO: <41.500MB -2.9%) vs baseline: +5.3% ✅ bytes_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.1% Memory: ✅ 40.120MB (SLO: <41.500MB -3.3%) vs baseline: +3.7% ✅ bytesio_aspectTime: ✅ 1.332µs (SLO: <10.000µs 📉 -86.7%) vs baseline: +2.0% Memory: ✅ 40.186MB (SLO: <41.500MB -3.2%) vs baseline: +4.0% ✅ bytesio_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 40.221MB (SLO: <41.500MB -3.1%) vs baseline: +4.1% ✅ capitalize_aspectTime: ✅ 0.733µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.1% Memory: ✅ 40.306MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 0.433µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.7% Memory: ✅ 40.249MB (SLO: <41.500MB -3.0%) vs baseline: +4.1% ✅ casefold_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.9% Memory: ✅ 40.290MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.2% Memory: ✅ 40.303MB (SLO: <41.500MB -2.9%) vs baseline: +4.0% ✅ decode_aspectTime: ✅ 0.727µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.7% Memory: ✅ 40.405MB (SLO: <41.500MB -2.6%) vs baseline: +5.2% ✅ decode_noaspectTime: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.3% Memory: ✅ 40.123MB (SLO: <41.500MB -3.3%) vs baseline: +3.6% ✅ encode_aspectTime: ✅ 0.709µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.6% Memory: ✅ 40.082MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3% Memory: ✅ 40.242MB (SLO: <41.500MB -3.0%) vs baseline: +3.8% ✅ format_aspectTime: ✅ 3.357µs (SLO: <10.000µs 📉 -66.4%) vs baseline: -0.8% Memory: ✅ 40.286MB (SLO: <41.500MB -2.9%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 3.486µs (SLO: <10.000µs 📉 -65.1%) vs baseline: -2.5% Memory: ✅ 40.308MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 0.773µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.3% Memory: ✅ 40.066MB (SLO: <41.500MB -3.5%) vs baseline: +3.6% ✅ format_noaspectTime: ✅ 0.590µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -1.1% Memory: ✅ 40.263MB (SLO: <41.500MB -3.0%) vs baseline: +3.9% ✅ index_aspectTime: ✅ 0.356µs (SLO: <10.000µs 📉 -96.4%) vs baseline: ~same Memory: ✅ 40.259MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.2% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% ✅ join_aspectTime: ✅ 1.336µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.9% Memory: ✅ 40.240MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6% Memory: ✅ 40.367MB (SLO: <41.500MB -2.7%) vs baseline: +5.2% ✅ ljust_aspectTime: ✅ 2.595µs (SLO: <20.000µs 📉 -87.0%) vs baseline: +0.8% Memory: ✅ 40.201MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ ljust_noaspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.0% Memory: ✅ 40.163MB (SLO: <41.500MB -3.2%) vs baseline: +3.7% ✅ lower_aspectTime: ✅ 2.265µs (SLO: <10.000µs 📉 -77.3%) vs baseline: +1.1% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 0.364µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.4% Memory: ✅ 40.303MB (SLO: <41.500MB -2.9%) vs baseline: +4.0% ✅ lstrip_aspectTime: ✅ 2.239µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +0.6% Memory: ✅ 40.286MB (SLO: <41.500MB -2.9%) vs baseline: +4.4% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 40.102MB (SLO: <41.500MB -3.4%) vs baseline: +3.6% ✅ modulo_aspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +4.7% Memory: ✅ 40.204MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.536µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -1.0% Memory: ✅ 40.185MB (SLO: <41.500MB -3.2%) vs baseline: +4.2% ✅ modulo_aspect_for_bytesTime: ✅ 0.980µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.4% Memory: ✅ 40.330MB (SLO: <41.500MB -2.8%) vs baseline: +4.4% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.240µs (SLO: <10.000µs 📉 -87.6%) vs baseline: +2.6% Memory: ✅ 40.127MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ modulo_noaspectTime: ✅ 0.627µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.4% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.0% ✅ replace_aspectTime: ✅ 4.814µs (SLO: <10.000µs 📉 -51.9%) vs baseline: -1.1% Memory: ✅ 40.348MB (SLO: <41.500MB -2.8%) vs baseline: +4.3% ✅ replace_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.7% Memory: ✅ 40.342MB (SLO: <41.500MB -2.8%) vs baseline: +4.3% ✅ repr_aspectTime: ✅ 0.904µs (SLO: <10.000µs 📉 -91.0%) vs baseline: ~same Memory: ✅ 40.219MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 40.366MB (SLO: <41.500MB -2.7%) vs baseline: +5.1% ✅ rstrip_aspectTime: ✅ 1.929µs (SLO: <20.000µs 📉 -90.4%) vs baseline: +0.5% Memory: ✅ 40.267MB (SLO: <41.500MB -3.0%) vs baseline: +4.4% ✅ rstrip_noaspectTime: ✅ 0.378µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.3% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% ✅ slice_aspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.8% Memory: ✅ 40.243MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.444µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -0.2% Memory: ✅ 40.204MB (SLO: <41.500MB -3.1%) vs baseline: +4.1% ✅ stringio_aspectTime: ✅ 1.529µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -0.2% Memory: ✅ 40.288MB (SLO: <41.500MB -2.9%) vs baseline: +4.1% ✅ stringio_noaspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.3% Memory: ✅ 40.039MB (SLO: <41.500MB -3.5%) vs baseline: +3.6% ✅ strip_aspectTime: ✅ 2.239µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +0.3% Memory: ✅ 40.182MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.9% Memory: ✅ 40.223MB (SLO: <41.500MB -3.1%) vs baseline: +4.0% ✅ swapcase_aspectTime: ✅ 2.770µs (SLO: <10.000µs 📉 -72.3%) vs baseline: 📈 +14.4% Memory: ✅ 40.346MB (SLO: <41.500MB -2.8%) vs baseline: +4.0% ✅ swapcase_noaspectTime: ✅ 0.533µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.9% Memory: ✅ 40.180MB (SLO: <41.500MB -3.2%) vs baseline: +3.7% ✅ title_aspectTime: ✅ 2.389µs (SLO: <10.000µs 📉 -76.1%) vs baseline: ~same Memory: ✅ 40.180MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.2% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +4.1% ✅ translate_aspectTime: ✅ 3.221µs (SLO: <10.000µs 📉 -67.8%) vs baseline: +0.5% Memory: ✅ 40.181MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ translate_noaspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.2% Memory: ✅ 40.205MB (SLO: <41.500MB -3.1%) vs baseline: +3.8% ✅ upper_aspectTime: ✅ 2.274µs (SLO: <10.000µs 📉 -77.3%) vs baseline: +2.2% Memory: ✅ 40.163MB (SLO: <41.500MB -3.2%) vs baseline: +4.2% ✅ upper_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.9% Memory: ✅ 40.264MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.018µs (SLO: <10.000µs 📉 -49.8%) vs baseline: 📈 +28.6% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.078µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.2% Memory: ✅ 40.482MB (SLO: <41.000MB 🟡 -1.3%) vs baseline: +5.3% ✅ ospathjoin_aspectTime: ✅ 5.939µs (SLO: <10.000µs 📉 -40.6%) vs baseline: ~same Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ ospathjoin_noaspectTime: ✅ 2.271µs (SLO: <10.000µs 📉 -77.3%) vs baseline: ~same Memory: ✅ 40.088MB (SLO: <41.000MB -2.2%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.248µs (SLO: <10.000µs 📉 -67.5%) vs baseline: -0.7% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.579µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +1.8% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.2% ✅ ospathsplit_aspectTime: ✅ 4.516µs (SLO: <10.000µs 📉 -54.8%) vs baseline: -0.6% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.577µs (SLO: <10.000µs 📉 -84.2%) vs baseline: ~same Memory: ✅ 40.521MB (SLO: <41.000MB 🟡 -1.2%) vs baseline: +5.3% ✅ ospathsplitdrive_aspectTime: ✅ 3.433µs (SLO: <10.000µs 📉 -65.7%) vs baseline: +0.2% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.690µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.2% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.287µs (SLO: <10.000µs 📉 -57.1%) vs baseline: +0.3% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.372µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.7% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.3% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.423µs (SLO: <20.000µs 📉 -82.9%) vs baseline: 📈 +13.6% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 203.163µs (SLO: <220.000µs -7.7%) vs baseline: -1.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.287µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -1.2% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.807µs (SLO: <230.000µs -5.3%) vs baseline: -1.3% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.173µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.3% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.805µs (SLO: <150.000µs -9.5%) vs baseline: -0.7% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.117µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +0.8% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 214.944µs (SLO: <250.000µs 📉 -14.0%) vs baseline: -1.4% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.8% ✅ 100-count-metrics-100-timesTime: ✅ 20.402ms (SLO: <22.000ms -7.3%) vs baseline: +0.6% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.259ms (SLO: <2.300ms 🟡 -1.8%) vs baseline: -1.2% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.413ms (SLO: <1.550ms -8.9%) vs baseline: +0.7% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.224ms (SLO: <2.550ms 📉 -12.8%) vs baseline: +0.2% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.577µs (SLO: <20.000µs 📉 -77.1%) vs baseline: +0.7% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 173.797µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.6% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.172ms (SLO: <2.500ms 📉 -13.1%) vs baseline: -0.3% Memory: ✅ 35.979MB (SLO: <36.500MB 🟡 -1.4%) vs baseline: +5.1% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
bc0739b to
a2529a3
Compare
Description
Provides proper support for API10 when inner requests are automatically redirected.
Testing
This was tested on System tests on new system tests for api10 redirect
DataDog/system-tests#5801
APPSEC-60065