Skip to content

Add Credit Card Numbers to Data Security Page #30579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brett0000FF
Copy link
Contributor

@brett0000FF brett0000FF commented Jul 18, 2025

What does this PR do? What is the motivation?

This undocumented feature automatically detects and redacts Primary Account Numbers (PANs) found in trace metadata across all programming languages.

The documentation now includes:

  • Updates to the data category tables to reflect that credit card numbers are collected by libraries and obfuscated by the Agent.
  • A new "Credit Card" tab under the Agent Trace Obfuscation section with configuration details.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner July 18, 2025 22:37
@brett0000FF brett0000FF requested a review from ajgajg1134 July 18, 2025 22:37
Copy link
Contributor

github-actions bot commented Jul 18, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@brett0000FF
Copy link
Contributor Author

@ajgajg1134 - Hello! Looks like you had written the internal docs for this content. When you have a sec, could you please verify my additions? Thanks!

@brett0000FF brett0000FF changed the title Add missing 'credit card numbers' info Add Credit Card Numbers to Data Security Page Jul 18, 2025
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor suggestions.


Scans all span metadata for numbers that appear to be credit card numbers. Any values that match are replaced with `?`. This check affects all span types and is enabled by default.

**Note**: Scanning looks for values that are exactly credit card numbers (allowing for internal whitespace). If a meta value has additional string data, this obfuscator considers that value to not be a credit card number. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: Scanning looks for values that are exactly credit card numbers (allowing for internal whitespace). If a meta value has additional string data, this obfuscator considers that value to not be a credit card number. For example:
**Note**: Scanning looks for values that are exactly credit card numbers (allowing for internal whitespace). If a metavalue has additional string data, this obfuscator determine that value is not a credit card number. For example:

Comment on lines +428 to +429
- A meta value of `4111 1111 1111 1111` is redacted to `?`.
- A meta value of `CC-4111 1111 1111 1111` is **not** redacted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A meta value of `4111 1111 1111 1111` is redacted to `?`.
- A meta value of `CC-4111 1111 1111 1111` is **not** redacted.
- A metavalue of `4111 1111 1111 1111` is redacted to `?`.
- A metavalue of `CC-4111 1111 1111 1111` is **not** redacted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants