Skip to content

Commit d605a5b

Browse files
steveny91maycmlee
andauthored
Move a param that was enabled by default further up the config (#21742)
* change the order of params for better visibility * nit * Rename 21732.fixed to 21742.fixed * Update apache/assets/configuration/spec.yaml Co-authored-by: May Lee <[email protected]> * re-sync --------- Co-authored-by: May Lee <[email protected]>
1 parent 50684a4 commit d605a5b

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

apache/assets/configuration/spec.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,20 @@ files:
1010
options:
1111
- name: apache_status_url
1212
required: true
13+
display_priority: 2
1314
description: Status url of your Apache server.
1415
value:
1516
example: http://localhost/server-status?auto
1617
type: string
1718
- template: instances/http
1819
- template: instances/default
1920
overrides:
21+
disable_generic_tags.display_priority: 1
2022
disable_generic_tags.hidden: False
2123
disable_generic_tags.enabled: True
2224
disable_generic_tags.description: |
23-
Generic tags such as `host` will be replaced by `apache_host` to avoid
24-
getting mixed with other integration tags.
25+
Generic tags such as `host` will be replaced by `apache_host` to prevent
26+
mixing them up with tags from other integrations. Datadog recommends setting this to `true` to avoid confusion.
2527
- template: logs
2628
example:
2729
- type: file

apache/changelog.d/21742.fixed

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Slight reorganization of config params for better visibility

apache/datadog_checks/apache/data/conf.yaml.example

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,12 @@ instances:
5050
#
5151
- apache_status_url: http://localhost/server-status?auto
5252

53+
## @param disable_generic_tags - boolean - optional - default: false
54+
## Generic tags such as `host` will be replaced by `apache_host` to prevent
55+
## mixing them up with tags from other integrations. Datadog recommends setting this to `true` to avoid confusion.
56+
#
57+
disable_generic_tags: true
58+
5359
## @param proxy - mapping - optional
5460
## This overrides the `proxy` setting in `init_config`.
5561
##
@@ -400,12 +406,6 @@ instances:
400406
#
401407
# empty_default_hostname: false
402408

403-
## @param disable_generic_tags - boolean - optional - default: false
404-
## Generic tags such as `host` will be replaced by `apache_host` to avoid
405-
## getting mixed with other integration tags.
406-
#
407-
disable_generic_tags: true
408-
409409
## @param metric_patterns - mapping - optional
410410
## A mapping of metrics to include or exclude, with each entry being a regular expression.
411411
##

0 commit comments

Comments
 (0)