Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change prefix for apollo integration #2529

Open
BrynCooke opened this issue Nov 4, 2024 · 1 comment
Open

Change prefix for apollo integration #2529

BrynCooke opened this issue Nov 4, 2024 · 1 comment

Comments

@BrynCooke
Copy link

I work for Apollo and am following up on an issue raised by a user regarding tag management.

The Apollo integration specifies that metrics that have a prefix apollo. are part of an integration:
https://github.com/DataDog/integrations-extras/blob/master/apollo/manifest.json#L35

Apparently having this prefix reserved limits users' from managing tags via the DD UI.

After further investigation, we’ve identified that the reason you’re unable to manage tags for these custom metrics is that they are using the apollo. prefix. This prefix is reserved for Apollo out-of-the-box (OOTB) metrics, which is why tag management is restricted.

Some of our products emit metrics that use the apollo. prefix, and users should be able to manage tags.
Are there any avenues for us to change the integrated metrics to the following prefixes:

  • apollo.operations.
  • apollo.engine.

What would be needed from our side to enable this to happen?
abernix added a commit to abernix/integrations-extras that referenced this issue Nov 19, 2024
@abernix
[Apollo] Tighten namespace around metrics
ba4758b 
This tightens the namespace which are part of our Datadog Marketplace integration to just the set of operations which from the integration rather than those that are emitted by our on-prem product, Apollo Router — which emits its metrics into an `apollo.router.` prefixed namespace, which should _not_ prevent users from losing control over the management of tags in their UI.

Relates to DataDog#2529
abernix added a commit to apollographql/integrations-extras that referenced this issue Nov 19, 2024
@abernix
[Apollo] Tighten namespace around metrics
7e3cb7a 
This tightens the namespace which are part of our Datadog Marketplace integration to just the set of operations which from the integration rather than those that are emitted by our on-prem product, Apollo Router — which emits its metrics into an `apollo.router.` prefixed namespace, which should _not_ prevent users from losing control over the management of tags in their UI.

Relates to DataDog#2529
abernix added a commit to apollographql/integrations-extras that referenced this issue Nov 19, 2024
@abernix
[Apollo] Tighten namespace around metrics
1ef2a8e 
This tightens the namespace which pertains to our DataDog Marketplace integration to **just** the set of metrics which are emitted (from the SaaS side of our Apollo product) which pertain to the Marketplace integration rather than those that are emitted by our (different) on-prem product, Apollo Router which emits its metrics into an `apollo.router.`-prefixed namespace.  This `apollo.router.` namespace should _not_ prevent users from losing control over the management of tags in their UI.

Relates to DataDog#2529
@abernix abernix mentioned this issue Nov 19, 2024
Draft
5 tasks
@abernix
Copy link

abernix commented Nov 19, 2024

I opened a draft PR to try and address this, but do still need guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrynCooke @abernix