Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflectiz integration release (ECOINT-23) #2580

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Reflectiz integration release (ECOINT-23) #2580

wants to merge 40 commits into from

Conversation

elie-b-ref
Copy link

@elie-b-ref elie-b-ref commented Jan 16, 2025 •
edited
Loading

What does this PR do?

The PR is intended to provide Datadog with the necessary files for the integration built with Reflectiz, the integration is a tile-only-listing.

Motivation

After talking with Datadog representative we started working on this integration, now that it is done we would like to publish it

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@elie-b-ref elie-b-ref requested review from a team as code owners January 16, 2025 08:08
@elie-b-ref elie-b-ref requested a review from a team as a code owner January 16, 2025 08:23
@mgashaj mgashaj changed the title Reflectiz integration release Reflectiz integration release (ECOINT-23) Jan 16, 2025
@aliciascott aliciascott added the editorial review Waiting on a more in-depth review from a docs team editor label Jan 16, 2025
@aliciascott
Copy link
Contributor

Thank you! I have created an editorial review for our team to review further.

neko-dd
neko-dd reviewed Jan 16, 2025
View reviewed changes
@elie-b-ref
Copy link
Author

Thank you for your review, I made the necessary updates and checked everything was working fine

@dd-dominic dd-dominic self-assigned this Jan 21, 2025
dd-dominic
dd-dominic requested changes Jan 21, 2025
View reviewed changes
dd-dominic
dd-dominic requested changes Jan 21, 2025
View reviewed changes
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed iliakur’s stale review February 23, 2025 07:49

Review from iliakur is dismissed.
Related teams and files:

  • agent-integrations
    • reflectiz/README.md
@elie-b-ref
Copy link
Author

Hello
Thanks for the change suggestions
I applied all the changes requested
I hope it will fit all your requirements

@JoshPatel13 JoshPatel13 added the assets/no-deploy Prevents APW from deploying this PR in staging label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Neale Kyle-Neale Kyle-Neale approved these changes

@JoshPatel13 JoshPatel13 JoshPatel13 approved these changes

@dd-dominic dd-dominic dd-dominic approved these changes

@audesikorav audesikorav audesikorav approved these changes

@neko-dd neko-dd neko-dd approved these changes

@iliakur iliakur iliakur left review comments

Assignees

@dd-dominic dd-dominic

Labels
agent/approved assets/no-deploy Prevents APW from deploying this PR in staging docs/review-requested ecosystems/approved editorial review Waiting on a more in-depth review from a docs team editor kind/technology-partner product/approved product/logos-complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@elie-b-ref @aliciascott @neko-dd @dd-dominic @iliakur @Kyle-Neale @JoshPatel13 @audesikorav