Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Harness Notifications integration (ECOINT-91) #2596

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dd-pub-platform[bot]
Copy link
Contributor

Integration Harness Notifications has been created in publishing platform

@dd-pub-platform dd-pub-platform bot requested review from a team as code owners February 3, 2025 18:28
@buraizu
Copy link
Contributor

buraizu commented Feb 3, 2025

Created DOCS-10000 to review

@buraizu buraizu added the editorial review Waiting on a more in-depth review from a docs team editor label Feb 3, 2025
@eho1307 eho1307 requested a review from dd-dominic February 5, 2025 16:40
@dd-dominic dd-dominic self-assigned this Feb 7, 2025
@dd-dominic dd-dominic changed the title Add Harness Notifications integration Add Harness Notifications integration (ECOINT-91) Feb 7, 2025
@@ -0,0 +1,64 @@
{
"app_id": "harness-harness-notifications",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"app_id": "harness-harness-notifications",
"app_id": "harness-notifications",

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback and a couple of comments about links in the headers.

@@ -0,0 +1,91 @@
{
"title": "Harness Notifications Integration Overview",
"description": "This dashboard provides a high-level overview of Notification events from Harness. ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "This dashboard provides a high-level overview of Notification events from Harness. ",
"description": "This dashboard provides a high-level overview of notification events from Harness.",

"id": 6544225029855812,
"definition": {
"type": "note",
"content": "This dashboard provides a high-level overview of Notification events from Harness. ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"content": "This dashboard provides a high-level overview of Notification events from Harness. ",
"content": "This dashboard provides a high-level overview of notification events from Harness.",

},
{
"media_type": "image",
"caption": "Select Pipeline Events for notification",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"caption": "Select Pipeline Events for notification",
"caption": "Select pipeline events for notification",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants