-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust agora.rtc.app_id.online_user and agora.rtc.app_id.online_channel type from count to gauge (ECOINT-94) #2599
base: master
Are you sure you want to change the base?
Conversation
…pp_id.online_channel type from count to gauge
@zicat please also update the CODEOWNERS file to reflect "agora_analytics" instead of "agora_analytic". For example, "/agora_analytic/*metadata.csv" should be "/agora_analytics/*metadata.csv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from docs
Review from steveny91 is dismissed.
Related teams and files:
- agent-integrations
- .github/CODEOWNERS
@dd-dominic Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zicat Please add a new entry to the changelog file.
I noticed the current changelog is in reverse order, so please rearrange so that most recent entries are first.
For example:
## 1.0.2 / 2025-02-24
***Changed***
* Updated metric type from count to gauge for `agora.trc.app_Id.online_user` and `agora.rtc.app_id.online_channel`
## 1.0.1 / 2024-10-15
* Update Dashboard Agora Analytics with new widgets for chat metrics
[etc.]
…pp_id.online_channel type from count to gauge
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?