Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust agora.rtc.app_id.online_user and agora.rtc.app_id.online_channel type from count to gauge (ECOINT-94) #2599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zicat
Copy link

@zicat zicat commented Feb 10, 2025

…pp_id.online_channel type from count to gauge

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

…pp_id.online_channel type from count to gauge
@zicat zicat requested a review from a team as a code owner February 10, 2025 06:46
@zicat zicat requested a review from london-wharton February 10, 2025 06:46
@dd-dominic dd-dominic changed the title Adjust agora.rtc.app_id.online_user and agora.rtc.app_id.online_channel type from count to gauge Adjust agora.rtc.app_id.online_user and agora.rtc.app_id.online_channel type from count to gauge (ECOINT-94) Feb 11, 2025
steveny91
steveny91 previously approved these changes Feb 11, 2025
@dd-dominic
Copy link
Collaborator

@zicat please also update the CODEOWNERS file to reflect "agora_analytics" instead of "agora_analytic".

For example, "/agora_analytic/*metadata.csv" should be "/agora_analytics/*metadata.csv"

@dd-dominic dd-dominic requested a review from a team February 11, 2025 20:50
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from docs

@zicat zicat requested a review from a team as a code owner February 17, 2025 06:22
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed steveny91’s stale review February 17, 2025 06:22

Review from steveny91 is dismissed.
Related teams and files:

  • agent-integrations
    • .github/CODEOWNERS
@zicat
Copy link
Author

zicat commented Feb 17, 2025

@zicat please also update the CODEOWNERS file to reflect "agora_analytics" instead of "agora_analytic".

For example, "/agora_analytic/*metadata.csv" should be "/agora_analytics/*metadata.csv"

@dd-dominic Done

Copy link
Collaborator

@dd-dominic dd-dominic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zicat Please add a new entry to the changelog file.

I noticed the current changelog is in reverse order, so please rearrange so that most recent entries are first.

For example:

## 1.0.2 / 2025-02-24

***Changed***

* Updated metric type from count to gauge for `agora.trc.app_Id.online_user` and `agora.rtc.app_id.online_channel`

## 1.0.1 / 2024-10-15

* Update Dashboard Agora Analytics with new widgets for chat metrics

[etc.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants