-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Celerdata] Add a grok expression to parse the new log format of BE (ECOINT-101) #2603
base: master
Are you sure you want to change the base?
Conversation
The failed check reported that I forgot to execute 'ddev validate models celerdata -s'. Even after I ran I also tried running
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, feel free to fix the validation. The changes you describe are fine.
@iliakur can you confirm if the failed validation needs to be fixed in this case? Looks like @yandongxiao attempted to run the validation command but it was going to modify the code - is this expected? |
Yes to both @dd-dominic |
@yandongxiao please run validation command |
Signed-off-by: yandongxiao <[email protected]>
Co-authored-by: Dominic Medina <[email protected]>
Co-authored-by: Dominic Medina <[email protected]>
Co-authored-by: Dominic Medina <[email protected]>
Signed-off-by: yandongxiao <[email protected]>
I have tried running |
@iliakur The developer ran the validation and committed the changes, but looks like they're still receiving the same error. Any idea what may be causing this? |
What does this PR do?
Add a grok expression to parse the new log format of BE
Motivation
The newest log format for BE component of StarRocks has changed, so we need to append a new grok expression.
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?