Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 add rum-react documentation to the integration page #2604

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

📝 add rum-react documentation to the integration page #2604

wants to merge 8 commits into from

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Feb 13, 2025 •
edited
Loading

What does this PR do?

Update the rum_react integration page to add the new rum-react plugin documentation. In the future, we'll remove the documentation from the package readme and just add a link to the integration doc page.

Rendered

Motivation

We are in the process of releasing the official rum-react integration plugin.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • N/A Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • N/A If this PR includes a log pipeline, please add a description describing the remappers and processors.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners February 13, 2025 09:50
Miz85
Miz85 approved these changes Feb 13, 2025
View reviewed changes
Copy link

@Miz85 Miz85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I only have one comment, let me know what you think.

rtrieu
rtrieu requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback to comply with our style guide but otherwise looks good.

jcdesousa
jcdesousa reviewed Feb 20, 2025
View reviewed changes
jcdesousa
jcdesousa reviewed Feb 20, 2025
View reviewed changes
jcdesousa
jcdesousa previously approved these changes Feb 20, 2025
View reviewed changes
Copy link

@jcdesousa jcdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpick comment.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed jcdesousa’s stale review February 20, 2025 12:57

Review from jcdesousa is dismissed.
Related teams and files:

  • rum-app
    • rum_react/README.md
mquentin
mquentin approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@mquentin mquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miz85 Miz85 Miz85 approved these changes

@mquentin mquentin mquentin approved these changes

@rtrieu rtrieu rtrieu approved these changes

@jcdesousa jcdesousa jcdesousa left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenoitZugmeyer @Miz85 @mquentin @jcdesousa @rtrieu