[K9VULN-3784] Use root path to properly find config file for exclusions #69
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the way we download/clone the repository files for IaC scanning and the fact that we expect the config file to be located at the root of the repository we were previously assuming that KICS is being run in the same directory as the repository root. However we actually download the files to a tmp directory and then run KICS on that dir which means the KICS base dir and the repository base dir don't match up.
For config file exclusions we ONLY look at the base dir and so we aren't properly finding the config file.
This change now prepends the correct tmp dir to the path where we look for the config file to ensure we can properly identify it if it is present.