feat: add dev container for consistent development environment #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensures consistent development setup - includes necessary dependencies and configurations - allows step-in for things like how container id is generated since the whole workspace is inside a container
ivoanjo
approved these changes
Feb 26, 2025
VianneyRuhlmann
approved these changes
Feb 26, 2025
ekump
approved these changes
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
==========================================
- Coverage 71.79% 71.78% -0.01%
==========================================
Files 328 328
Lines 48605 48605
==========================================
- Hits 34894 34893 -1
- Misses 13711 13712 +1
|
BenchmarksComparisonBenchmark execution time: 2025-02-26 13:42:13 Comparing candidate commit 4bdfc64 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. scenario:concentrator/add_spans_to_concentrator
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
bantonsson
reviewed
Feb 26, 2025
| // Use 'mounts' to make the cargo cache persistent in a Docker Volume. | ||
| "mounts": [ | ||
| { | ||
| "source": "devcontainer-cargo-cache-${devcontainerId}", |
There was a problem hiding this comment.
So what does this translate to? Is it using Docker cache mounts underneath? I mean something like --mount=type=cache,target=/usr/local/cargo, or is it specific to dev containers?
There was a problem hiding this comment.
you get a volume which is attached to dev container just like any other volume
docker volume ls | grep devcontainer-cargo-cache
local devcontainer-cargo-cache-1u4p07avg375gi7o172o2cfupr5iafgjj9t7hvog8dscsv7co5df
since it is container specific, running the same container would give you same volume and helps avoiding repetitive whole world of internet download.
There was a problem hiding this comment.
Ok, so it's manually maintaining what --mount=type=cache,... gives you.
Do you know if it has a cached target directory as well for the output of the build? I'm just curious.
There was a problem hiding this comment.
I didn't try but I think you can as per spec https://github.com/devcontainers/spec/blob/main/schemas/devContainer.base.schema.json#L711C8-L711C12
you can bring your own arbitrary location if this is what you mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I went with minimal setup and targeting only one OS, but this can be extended with multiple container (debian, alpine etc)
Motivation
I have been using it locally by keeping in my stashes, but this is general problem since we are all (or almost) on osx and want to test and debug how the libraries behave on linux.
Additional Notes
none.
How to test the change?
Follow the readme.