Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EINTR in blocking ipc sender #900

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Handle EINTR in blocking ipc sender #900

merged 5 commits into from
Feb 26, 2025

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Feb 26, 2025

Without this change file descriptions were not sent when send_with_fd was interrupted by a signal, causing the connection to become broken.

Also use statm for memory tracking in sidecar (we don't need full accuracy for the watchdog).

Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
We don't need full accruacy for the watchdog.

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi requested review from a team as code owners February 26, 2025 17:12
@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-02-26 17:41:33

Comparing candidate commit 6a448f7 in PR branch bob/tmp with baseline commit a207606 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.997ms 6.010ms ± 0.006ms 6.009ms ± 0.003ms 6.013ms 6.017ms 6.025ms 6.055ms 0.76% 2.851 20.518 0.09% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.009ms; 6.011ms] or [-0.013%; +0.013%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.053µs 5.152µs ± 0.054µs 5.181µs ± 0.033µs 5.201µs 5.214µs 5.217µs 5.219µs 0.73% -0.255 -1.673 1.04% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.144µs; 5.159µs] or [-0.145%; +0.145%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 65.286µs 65.517µs ± 0.230µs 65.477µs ± 0.071µs 65.558µs 65.728µs 66.218µs 67.946µs 3.77% 6.910 64.368 0.35% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [65.485µs; 65.549µs] or [-0.049%; +0.049%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.696µs 209.095µs ± 0.137µs 209.100µs ± 0.085µs 209.183µs 209.304µs 209.440µs 209.604µs 0.24% 0.074 0.771 0.07% 0.010µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4770894.364op/s 4782525.975op/s ± 3137.320op/s 4782402.037op/s ± 1944.051op/s 4784469.771op/s 4787471.221op/s 4790030.607op/s 4791663.783op/s 0.19% -0.069 0.766 0.07% 221.842op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.258µs 18.346µs ± 0.113µs 18.356µs ± 0.040µs 18.376µs 18.408µs 18.447µs 19.763µs 7.67% 9.804 120.736 0.62% 0.008µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 50599110.476op/s 54508754.055op/s ± 317827.718op/s 54479072.493op/s ± 118902.885op/s 54663126.425op/s 54759482.548op/s 54763911.008op/s 54769679.689op/s 0.53% -9.313 112.755 0.58% 22473.813op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.682µs 10.744µs ± 0.025µs 10.741µs ± 0.016µs 10.759µs 10.783µs 10.807µs 10.829µs 0.83% 0.384 0.438 0.23% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 92340825.726op/s 93074595.189op/s ± 217666.383op/s 93103501.401op/s ± 134363.935op/s 93224079.493op/s 93402436.427op/s 93566986.921op/s 93617719.962op/s 0.55% -0.368 0.417 0.23% 15391.338op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.076µs; 209.114µs] or [-0.009%; +0.009%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4782091.173op/s; 4782960.778op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.331µs; 18.362µs] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54464706.190op/s; 54552801.920op/s] or [-0.081%; +0.081%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.741µs; 10.748µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good throughput [93044428.721op/s; 93104761.656op/s] or [-0.032%; +0.032%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.646µs 33.255µs ± 1.006µs 32.786µs ± 0.060µs 32.928µs 35.368µs 35.404µs 37.272µs 13.68% 1.778 1.556 3.02% 0.071µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.115µs; 33.394µs] or [-0.419%; +0.419%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 53.827ms 54.352ms ± 0.284ms 54.386ms ± 0.145ms 54.499ms 54.649ms 55.328ms 55.441ms 1.94% 0.744 2.338 0.52% 0.020ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [54.313ms; 54.392ms] or [-0.072%; +0.072%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.629µs 505.705µs ± 0.711µs 505.711µs ± 0.259µs 505.930µs 506.301µs 506.611µs 513.990µs 1.64% 7.875 90.264 0.14% 0.050µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1945564.615op/s 1977440.018op/s ± 2751.099op/s 1977413.652op/s ± 1014.774op/s 1978622.468op/s 1980306.666op/s 1981278.617op/s 1981653.631op/s 0.21% -7.748 88.354 0.14% 194.532op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.637µs 453.340µs ± 0.328µs 453.328µs ± 0.167µs 453.473µs 453.784µs 454.268µs 455.961µs 0.58% 2.679 19.428 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2193169.789op/s 2205850.338op/s ± 1594.349op/s 2205909.521op/s ± 814.510op/s 2206769.137op/s 2207970.728op/s 2209039.253op/s 2209276.842op/s 0.15% -2.649 19.132 0.07% 112.737op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 176.114µs 176.882µs ± 0.240µs 176.923µs ± 0.151µs 177.045µs 177.230µs 177.376µs 177.410µs 0.28% -0.504 0.370 0.14% 0.017µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5636649.218op/s 5653510.878op/s ± 7676.462op/s 5652168.197op/s ± 4831.051op/s 5658217.710op/s 5667214.937op/s 5674499.179op/s 5678134.791op/s 0.46% 0.512 0.383 0.14% 542.808op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.548µs 37.660µs ± 0.045µs 37.658µs ± 0.031µs 37.688µs 37.730µs 37.785µs 37.839µs 0.48% 0.543 1.279 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26427909.963op/s 26553141.028op/s ± 32026.901op/s 26554729.220op/s ± 21650.865op/s 26576579.274op/s 26602766.218op/s 26615688.808op/s 26632779.036op/s 0.29% -0.533 1.251 0.12% 2264.644op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.096µs 48.322µs ± 0.248µs 48.218µs ± 0.117µs 48.545µs 48.617µs 48.658µs 50.053µs 3.81% 1.774 9.609 0.51% 0.018µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19978695.246op/s 20694844.360op/s ± 105472.403op/s 20739271.136op/s ± 50336.437op/s 20787290.057op/s 20788953.107op/s 20790527.598op/s 20791859.096op/s 0.25% -1.649 8.467 0.51% 7458.025op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.607µs; 505.804µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1977058.742op/s; 1977821.294op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.295µs; 453.386µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2205629.376op/s; 2206071.299op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.848µs; 176.915µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5652446.994op/s; 5654574.762op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.654µs; 37.667µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26548702.407op/s; 26557579.648op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.288µs; 48.357µs] or [-0.071%; +0.071%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20680226.899op/s; 20709461.820op/s] or [-0.071%; +0.071%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.918µs 3.919µs 0.12% -3.525 28.423 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 255199540.880op/s 255503270.338op/s ± 156297.555op/s 255498733.080op/s ± 67692.978op/s 255564502.091op/s 255708677.492op/s 255873258.407op/s 256878845.645op/s 0.54% 3.558 28.791 0.06% 11051.906op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 80.937µs 82.664µs ± 0.700µs 82.742µs ± 0.524µs 83.153µs 83.766µs 84.011µs 84.123µs 1.67% -0.051 -0.755 0.85% 0.050µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11887325.305op/s 12098066.439op/s ± 102577.754op/s 12085700.132op/s ± 76927.817op/s 12176048.203op/s 12258299.152op/s 12311095.140op/s 12355226.119op/s 2.23% 0.083 -0.747 0.85% 7253.343op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 78.315µs 79.513µs ± 0.408µs 79.488µs ± 0.296µs 79.836µs 80.143µs 80.286µs 80.843µs 1.70% 0.012 0.064 0.51% 0.029µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12369701.750op/s 12576841.677op/s ± 64502.133op/s 12580537.115op/s ± 46990.982op/s 12623527.305op/s 12680923.461op/s 12721956.776op/s 12768967.749op/s 1.50% 0.020 0.066 0.51% 4560.990op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.913µs ± 0.002µs 3.913µs ± 0.001µs 3.915µs 3.916µs 3.919µs 3.920µs 0.17% -2.284 17.309 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255091220.561op/s 255528622.206op/s ± 155094.940op/s 255533599.595op/s ± 69640.389op/s 255590044.779op/s 255774521.374op/s 255898492.555op/s 256733658.817op/s 0.47% 2.309 17.533 0.06% 10966.868op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 75.114µs 76.205µs ± 0.430µs 76.191µs ± 0.276µs 76.477µs 76.962µs 77.191µs 77.237µs 1.37% 0.039 -0.010 0.56% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 12947115.643op/s 13122852.472op/s ± 74080.279op/s 13124987.451op/s ± 47343.840op/s 13168401.442op/s 13241483.004op/s 13297979.046op/s 13313161.876op/s 1.43% -0.006 -0.009 0.56% 5238.267op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.346µs 51.421µs ± 0.031µs 51.425µs ± 0.016µs 51.436µs 51.467µs 51.482µs 51.576µs 0.29% 0.296 2.478 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19388787.852op/s 19447306.280op/s ± 11673.745op/s 19445949.012op/s ± 5878.692op/s 19452492.151op/s 19467903.665op/s 19473771.498op/s 19475793.536op/s 0.15% -0.288 2.448 0.06% 825.458op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.026µs 6.037µs ± 0.004µs 6.037µs ± 0.002µs 6.039µs 6.043µs 6.048µs 6.052µs 0.25% 0.617 2.862 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165223940.261op/s 165633421.684op/s ± 98220.154op/s 165643780.501op/s ± 49064.389op/s 165680159.801op/s 165805976.550op/s 165864598.056op/s 165939168.123op/s 0.18% -0.609 2.844 0.06% 6945.214op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.897µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.921µs 3.931µs 0.44% 0.105 11.114 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254361260.661op/s 255488832.243op/s ± 190011.868op/s 255490432.942op/s ± 82833.006op/s 255576435.853op/s 255763631.318op/s 255908366.768op/s 256606951.338op/s 0.44% -0.076 11.110 0.07% 13435.868op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.843µs 66.522µs ± 0.340µs 66.472µs ± 0.230µs 66.760µs 67.169µs 67.388µs 67.460µs 1.49% 0.574 -0.149 0.51% 0.024µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14823679.741op/s 15032955.619op/s ± 76552.585op/s 15044005.223op/s ± 52165.540op/s 15094104.952op/s 15140192.201op/s 15169058.930op/s 15187675.626op/s 0.96% -0.551 -0.181 0.51% 5413.085op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.439µs 59.676µs ± 0.100µs 59.674µs ± 0.067µs 59.747µs 59.823µs 59.887µs 59.938µs 0.44% -0.093 -0.290 0.17% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16683992.861op/s 16757222.125op/s ± 28037.853op/s 16757614.129op/s ± 18830.564op/s 16776108.307op/s 16809324.893op/s 16816032.592op/s 16823864.652op/s 0.40% 0.102 -0.290 0.17% 1982.576op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.918µs 3.920µs 3.926µs 0.31% -0.892 9.429 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254727913.515op/s 255538523.530op/s ± 185014.682op/s 255525846.407op/s ± 73028.958op/s 255603195.041op/s 255832486.493op/s 255929694.011op/s 256733143.074op/s 0.47% 0.915 9.531 0.07% 13082.514op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.333µs 56.848µs ± 0.180µs 56.861µs ± 0.120µs 56.979µs 57.124µs 57.166µs 57.215µs 0.62% -0.321 -0.339 0.32% 0.013µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17477918.487op/s 17590801.140op/s ± 55784.226op/s 17586739.599op/s ± 37116.211op/s 17623809.811op/s 17693099.212op/s 17715969.546op/s 17751562.844op/s 0.94% 0.336 -0.322 0.32% 3944.540op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.347µs 51.437µs ± 0.035µs 51.433µs ± 0.013µs 51.450µs 51.497µs 51.515µs 51.680µs 0.48% 1.973 12.702 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19349774.158op/s 19441353.612op/s ± 13297.909op/s 19442587.984op/s ± 4897.000op/s 19446742.664op/s 19462768.308op/s 19472163.764op/s 19475445.358op/s 0.17% -1.951 12.551 0.07% 940.304op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.038µs ± 0.003µs 6.037µs ± 0.002µs 6.039µs 6.043µs 6.046µs 6.055µs 0.28% 0.539 3.280 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165164988.453op/s 165625659.038op/s ± 91147.010op/s 165633971.528op/s ± 47240.300op/s 165676907.225op/s 165764552.011op/s 165869306.570op/s 165894446.052op/s 0.16% -0.530 3.256 0.05% 6445.067op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.914µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [255481609.001op/s; 255524931.676op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.567µs; 82.761µs] or [-0.117%; +0.117%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12083850.149op/s; 12112282.729op/s] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [79.457µs; 79.570µs] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12567902.302op/s; 12585781.052op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [255507127.538op/s; 255550116.873op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [76.146µs; 76.265µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/378282246310005 throughput [13112585.658op/s; 13133119.286op/s] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.417µs; 51.425µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19445688.411op/s; 19448924.149op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.037µs; 6.038µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [165619809.316op/s; 165647034.053op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255462498.425op/s; 255515166.060op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.475µs; 66.569µs] or [-0.071%; +0.071%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15022346.167op/s; 15043565.071op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.662µs; 59.690µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16753336.348op/s; 16761107.901op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255512882.274op/s; 255564164.786op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.824µs; 56.873µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17583069.983op/s; 17598532.297op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.432µs; 51.442µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19439510.650op/s; 19443196.574op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.037µs; 6.038µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165613026.939op/s; 165638291.137op/s] or [-0.008%; +0.008%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.073µs 150.446µs ± 0.293µs 150.420µs ± 0.160µs 150.620µs 150.894µs 151.071µs 151.335µs 0.61% -0.543 2.813 0.19% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.405µs; 150.486µs] or [-0.027%; +0.027%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.260µs 3.169µs ± 1.347µs 2.989µs ± 0.023µs 3.011µs 3.648µs 7.975µs 17.335µs 479.98% 8.636 80.002 42.39% 0.095µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.982µs; 3.356µs] or [-5.890%; +5.890%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.341µs 2.395µs ± 0.016µs 2.393µs ± 0.007µs 2.403µs 2.423µs 2.430µs 2.444µs 2.12% -0.430 2.096 0.66% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.393µs; 2.397µs] or [-0.092%; +0.092%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.590µs 25.726µs ± 11.087µs 17.949µs ± 0.135µs 35.132µs 41.703µs 55.098µs 98.582µs 449.23% 2.046 8.535 42.99% 0.784µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.189µs; 27.262µs] or [-5.973%; +5.973%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a448f7 1740590967 bob/tmp
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 245.705ns 255.026ns ± 10.825ns 250.596ns ± 3.554ns 256.785ns 281.028ns 284.389ns 286.545ns 14.35% 1.470 0.971 4.23% 0.765ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.526ns; 256.527ns] or [-0.588%; +0.588%] None None None

Baseline

Omitted due to size.

@morrisonlevi
Copy link
Contributor

I approved, but of course that's dependent on getting jobs to pass ^_^

Using statm should fix one perf issue found with the sidecar, which does affect one customer that is reporting elevated overhead with APM.

Signed-off-by: Bob Weinand <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 39.47368% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (a207606) to head (6a448f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   71.78%   71.71%   -0.07%     
==========================================
  Files         328      328              
  Lines       48605    48615      +10     
==========================================
- Hits        34889    34866      -23     
- Misses      13716    13749      +33     
Components Coverage Δ
crashtracker 42.87% <ø> (+0.08%) ⬆️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.02% <ø> (ø)
data-pipeline-ffi 90.39% <ø> (ø)
ddcommon 80.08% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 90.16% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.63% <50.00%> (-0.05%) ⬇️
profiling 80.04% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.29% <0.00%> (-0.58%) ⬇️
sidecar-ffi 0.58% <ø> (-4.12%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 92.00% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 78.13% <ø> (ø)
trace-utils 93.26% <ø> (ø)

@bwoebi bwoebi enabled auto-merge (squash) February 26, 2025 17:43
@bwoebi bwoebi merged commit b145b2f into main Feb 26, 2025
31 checks passed
@bwoebi bwoebi deleted the bob/tmp branch February 26, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants