-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle EINTR in blocking ipc sender #900
Conversation
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
We don't need full accruacy for the watchdog. Signed-off-by: Bob Weinand <[email protected]>
BenchmarksComparisonBenchmark execution time: 2025-02-26 17:41:33 Comparing candidate commit 6a448f7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
I approved, but of course that's dependent on getting jobs to pass ^_^ Using statm should fix one perf issue found with the sidecar, which does affect one customer that is reporting elevated overhead with APM. |
Signed-off-by: Bob Weinand <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
- Coverage 71.78% 71.71% -0.07%
==========================================
Files 328 328
Lines 48605 48615 +10
==========================================
- Hits 34889 34866 -23
- Misses 13716 13749 +33
|
Without this change file descriptions were not sent when send_with_fd was interrupted by a signal, causing the connection to become broken.
Also use statm for memory tracking in sidecar (we don't need full accuracy for the watchdog).