Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.querystring doesn't support array parameters #75

Open
ebachle opened this issue May 11, 2024 · 1 comment
Open

http.querystring doesn't support array parameters #75

ebachle opened this issue May 11, 2024 · 1 comment

Comments

@ebachle
Copy link

ebachle commented May 11, 2024

In a request like this one (normally this is URL encoded):

http://host.example/something/entries?include[]=ask.placed.share&include[]=ask.placed.reminder&include[]=ask.placed.confirm.reminder&include[]=ask.matched.share&include[]=ask.matched.reminder&include[]=ask.payment_failed.reminder&include[]=ask.authorization_failed.reminder&include[]=ask.additional_days_to_ship_alert&include[]=ask.how_it_works.penalty&include[]=ask.condition_tutorial&include[]=bid.placed.share&include[]=bid.placed.reminder&include[]=bid.matched.share&include[]=bid.matched.reminder&include[]=bid.payment_failed.reminder&include[]=bid.authorization_failed.reminder&include[]=bid.additional_days_to_ship_alert&include[]=bid.how_it_works.penalty&include[]=bid.condition_tutorial&include[]=bid.confirm_condition&include[]=want.placed.share&include[]=want.placed.reminder&include[]=hold.placed.share&include[]=hold.placed.reminder&include[]=share&query=%7B%0A%20%20%22content_group%22%20:%20%22streetwear-clothing%22%0A%7D&locale=ja-jp

The trace only has the very last include[] query string array parameter of "share" in the include object.

Approximation from the trace:

queryString = {
	include = {
		share
	}
	locale = ja-jp
	query = %7B%0A%20%20%22content_group%22%20:%20%22streetwear-clothing%22%0A%7D
}
image

Not sure if this is an issue with the nginx module, the cpp tracer, or something I'm doing. But I'd be open to thoughts on how to resolve it.

@dmehala
Copy link
Contributor

dmehala commented May 13, 2024

Hello @ebachle

The NGINX module does not set those tags, nor the cpp tracer. In fact, the module only set the whole url as a span tag, then, the Datadog Agent or the backend split the url.

I can bring this ticket to the respective teams but there's nothing on the plugin nor the cpp tracer I can do (Well, I can split the URL in the cpp tracer but that will be costly, inefficient and add unnecessary tech debt).

In the meanwhile, I suggest to open a feature request here for visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants