Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to libddwaf 1.23.0 #175

Open
wants to merge 1 commit into
base: glopes/block-resp
Choose a base branch
from

Conversation

cataphract
Copy link
Contributor

No description provided.

@cataphract cataphract requested review from a team as code owners February 26, 2025 23:19
@cataphract cataphract requested review from pablomartinezbernardo and removed request for a team February 26, 2025 23:19
@cataphract cataphract force-pushed the glopes/libddwaf-upg-1.23.0 branch from 291cb10 to 743c5ce Compare February 26, 2025 23:23
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 52.09581% with 80 lines in your changes missing coverage. Please review.

Project coverage is 69.30%. Comparing base (7cfce28) to head (743c5ce).

Files with missing lines Patch % Lines
src/security/library.cpp 52.88% 37 Missing and 12 partials ⚠️
src/security/waf_remote_cfg.cpp 50.79% 26 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           glopes/block-resp     #175      +/-   ##
=====================================================
- Coverage              71.25%   69.30%   -1.96%     
=====================================================
  Files                     44       44              
  Lines                   6683     6486     -197     
  Branches                 948      922      -26     
=====================================================
- Hits                    4762     4495     -267     
- Misses                  1466     1538      +72     
+ Partials                 455      453       -2     
Files with missing lines Coverage Δ
src/security/library.h 80.00% <ø> (-20.00%) ⬇️
src/security/waf_remote_cfg.cpp 54.82% <50.79%> (-24.57%) ⬇️
src/security/library.cpp 60.36% <52.88%> (-1.40%) ⬇️

... and 2 files with indirect coverage changes

@Anilm3
Copy link
Contributor

Anilm3 commented Feb 27, 2025

Minor annoyance, but we might change the fallback on ASM_DD as we're considering supporting multiple configurations (check the RFC for the comments). I'll try to address that ASAP so it doesn't block you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants