feat: Implement baggage span tags feature by zacharycmontoya · Pull Request #246 · DataDog/nginx-datadog

Commits on Aug 30, 2025

TODO: Change the configuration from individual entries to one csv for the entire value. This tells us if the configuration is UNSET (so we apply default values) or if the configuration is disabled …
zacharycmontoya
committed

Commits on Aug 31, 2025

Commits on Sep 3, 2025

Update baggage_span_tags field from an unordered_set to a vector
zacharycmontoya
committed
Fix bug so that specifying one span tag with the wildcard key "*" obtains all baggage items from the header and creates a corresponding span tag for each.
zacharycmontoya
committed
Move calculation of baggage span tags to configuration-time so that we do not need to do a recursive lookup while handling each request.
zacharycmontoya
committed
Change the directive again: The user must set the 'datadog_baggage_span_tags' directive which accepts one or more tags for the list of configured baggage keys to add as span tags, as opposed to mul…
zacharycmontoya
committed
Update the API docs with a more complete description of the two directives:
zacharycmontoya
committed
Satisfy linter
zacharycmontoya
committed
Satisfy clang-format-14 formatting
zacharycmontoya
committed

Commits on Sep 10, 2025

Commits on Sep 26, 2025

Commits on Oct 3, 2025

Commits on Oct 8, 2025

Address an edge case: Throw a configuration error, when in the same configuration location, the user configures all baggage tag keys and then selects a list of baggage tag keys. The error alerts th…
zacharycmontoya
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Implement baggage span tags feature#246

feat: Implement baggage span tags feature#246
zacharycmontoya merged 23 commits intomasterfrom
zach.montoya/baggage-span-tags

Commits on Aug 30, 2025

TODO: Change the configuration from individual entries to one csv for the entire value. This tells us if the configuration is UNSET (so we apply default values) or if the configuration is disabled …

Commits on Aug 31, 2025

Two changes in one:

Convert the combined `datadog_baggage_span_tags` directive to individual `datadog_baggage_span_tag` directives, which feels more NGINX-y

Refactor and format test_baggage_span_tags.py. Also had a general disabled test

Small update to example conf

Small code comment update

Commits on Sep 3, 2025

Update baggage_span_tags field from an unordered_set to a vector

Fix bug so that specifying one span tag with the wildcard key "*" obtains all baggage items from the header and creates a corresponding span tag for each.

Move calculation of baggage span tags to configuration-time so that we do not need to do a recursive lookup while handling each request.

Change the directive again: The user must set the 'datadog_baggage_span_tags' directive which accepts one or more tags for the list of configured baggage keys to add as span tags, as opposed to mul…

Update the API docs with a more complete description of the two directives:

Satisfy linter

Satisfy clang-format-14 formatting

Commits on Sep 10, 2025

PR Feedback: Update tests to use tuples instead of lists

PR Feedback: Implement changes except for directive name, directive documentation, and improved wildcard logic

PR Feedback: Update the baggage_span_tags field to have the type 'std::variant<std::vector<std::string>, bool>'. This distinguishes between the first type containing baggage keys to set vs the seco…

Commits on Sep 26, 2025

Update docs for the baggage span_tags feature

Update test cases to ensure that if both "datadog_baggage_span_tags <key>" and "datadog_baggage_span_tags_enabled off" are set, then no baggage span tags are set

Commits on Oct 3, 2025

refactor: Large rename of "datadog_baggage_span_tags" to "datadog_baggage_tags"

refactor: Rename the "datadog_baggage_tags" directive to "datadog_baggage_tags_keys"

Update the 'datadog_baggage_tags_keys' directive so it's first argument is 'all' or 'select'. 'all' invokes the wildcard behavior while 'select' accepts a list of keys

Run formatter

Commits on Oct 8, 2025

Address an edge case: Throw a configuration error, when in the same configuration location, the user configures all baggage tag keys and then selects a list of baggage tag keys. The error alerts th…

feat: Implement baggage span tags feature#246zacharycmontoya merged 23 commits intomasterDataDog/nginx-datadog:masterfrom zach.montoya/baggage-span-tagsDataDog/nginx-datadog:zach.montoya/baggage-span-tagsCopy head branch name to clipboard

Commits

Commits on Aug 30, 2025

Commits on Aug 31, 2025

Commits on Sep 3, 2025

Commits on Sep 10, 2025

Commits on Sep 26, 2025

Commits on Oct 3, 2025

Commits on Oct 8, 2025

feat: Implement baggage span tags feature#246
zacharycmontoya merged 23 commits intomasterfrom
zach.montoya/baggage-span-tags