ci: Add system-tests

[cbeauchesne]

Add a job in circleCI that run system-tests. It will prevent introducing bug tested in system tests.

For now, I only added the default scenario, up to C++ team to decide what to add or remove later.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.48%. Comparing base (f05587d) to head (43ab2c7).

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   66.48%   66.48%           
=======================================
  Files          37       37           
  Lines        3554     3554           
  Branches      607      607           
=======================================
  Hits         2363     2363           
  Misses        875      875           
  Partials      316      316           

[dmehala]

This one is not necessary.

[cbeauchesne]

🤔 it's necessay for build-and-test but not for build-and-test-all ?

[dmehala]

LGTM, thank you @cbeauchesne. However I can see in the system-tests output:

Library: [email protected]
Weblog variant: nginx

How the weblog versioning is working? Is there a weblog versioning?

[cbeauchesne]

aha, good catch, I didn't expect you to see this. There are several issue here.

Currently, the version number for c++ is the version number of this present repo, where it should be the version of dd-trace-cpp

Second, I need to have a way to extract this version number from the ngx_http_datadog_module.so file, and I don't know how to do so. So shame on me, I went lazy, and I hardcoded a big version number, leaving this point for later.

If you know how to extract this version number, I can add it (it's inside system-tests repo). If you don't know, or if it's not possible (yet), my opinion is we can move forward with that hack, as long as the hardocded version is bigger than the current version, everything will works fine.

[cataphract]

aha, good catch, I didn't expect you to see this. There are several issue here.

Currently, the version number for c++ is the version number of this present repo, where it should be the version of dd-trace-cpp

Second, I need to have a way to extract this version number from the ngx_http_datadog_module.so file, and I don't know how to do so. So shame on me, I went lazy, and I hardcoded a big version number, leaving this point for later.

They can be fetched like this.

See also: https://github.com/DataDog/nginx-datadog/blob/master/src/version.cpp.in

[cbeauchesne]

thanks @cataphract , let me add this

-> DataDog/system-tests#2517

[dmehala]

They can be fetched like this.

That's smart. We should also those this for dd-trace-cpp instead of parsing version.h. This would have avoid the issue with prod we got this week

[cbeauchesne]

@dmehala could you merge the Pr? I don't have the right to do it myself 🙏