-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent 6 support breaks tag feature #386
Comments
@Deroin thanks for reporting this, I'm sorry you encoutered this. It looks like we'll have to patch the module to address this. Agent6 now relies on a different configuration, a YAML file, for it's configuration elements. I believe I may be able to provide a workaround soon - and a patch shortly after. Any chance you could share a snippet of the node configuration manifest that triggered the error? Please stay posted. Thanks again! 🙇 |
Should _patch_ the problem described in #386. Doesn't provide an alternative for agent6 though.
* Transition to 2.0 dropping legacy + EOL compatibility fixes * fixing multiple lint issues * [agent6] tags currently unsupported on agent6 Should _patch_ the problem described in #386. Doesn't provide an alternative for agent6 though. * [agent6] add tagging support for agent6 Also removing gem provider options, should be the same for P4 and P5. * [functions] tag6 return type unavailable on 4.6 * [spec] fixing spec tests to accomodate for refactor chagnges, improve coverage * [skip ci] updating gitignore * [apt] address beta repo management * [apt] remove agent according to facts * [reports] attempt switch to tkishel/system_gem provider for reporting * [apt] set correct uri for keyserver * Revert "[reports] attempt switch to tkishel/system_gem provider for reporting" This reverts commit 9008acc. * [ubuntu] default repo must be stable * [rhel] set right repo for agent5/6 * [yum] allow overriding repo from init * [rhel] fix downgrades/upgrades across repos * [spec] fixing apm-related tests * [yum] remove package on downgrade * [yum] fix legacy, agent6 repo facts * [apt] enable repo uri location override in main manifest * [apt] actually pass location(repo) to ubuntu manifests * [apt] allow configuring apt release * [agent6] enabled process and apm configuration + extra options for agents. * [agent6] single hash for additional options for all things agent6 * [lint] fix multiple linter issues * [puppet][2.x] updating docs - skip ci
Any news on this? I just installed and agent with tag 2.3.0 of this repo on puppet 4.10 and I get an empty set of tags. |
) * Transition to 2.0 dropping legacy + EOL compatibility fixes * fixing multiple lint issues * [agent6] tags currently unsupported on agent6 Should _patch_ the problem described in DataDog#386. Doesn't provide an alternative for agent6 though. * [agent6] add tagging support for agent6 Also removing gem provider options, should be the same for P4 and P5. * [functions] tag6 return type unavailable on 4.6 * [spec] fixing spec tests to accomodate for refactor chagnges, improve coverage * [skip ci] updating gitignore * [apt] address beta repo management * [apt] remove agent according to facts * [reports] attempt switch to tkishel/system_gem provider for reporting * [apt] set correct uri for keyserver * Revert "[reports] attempt switch to tkishel/system_gem provider for reporting" This reverts commit 9008acc. * [ubuntu] default repo must be stable * [rhel] set right repo for agent5/6 * [yum] allow overriding repo from init * [rhel] fix downgrades/upgrades across repos * [spec] fixing apm-related tests * [yum] remove package on downgrade * [yum] fix legacy, agent6 repo facts * [apt] enable repo uri location override in main manifest * [apt] actually pass location(repo) to ubuntu manifests * [apt] allow configuring apt release * [agent6] enabled process and apm configuration + extra options for agents. * [agent6] single hash for additional options for all things agent6 * [lint] fix multiple linter issues * [puppet][2.x] updating docs - skip ci
Tags will be included into config via
concat::fragment
on the agent5 config file/etc/dd-agent/datadog.conf
. Withagent6_enable
set totrue
this concat file will never be defined causing an error in puppet:The text was updated successfully, but these errors were encountered: