Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent 6 support breaks tag feature #386

Open
Deroin opened this issue Jan 22, 2018 · 4 comments
Open

Agent 6 support breaks tag feature #386

Deroin opened this issue Jan 22, 2018 · 4 comments
Assignees
Milestone

Comments

@Deroin
Copy link
Contributor

Deroin commented Jan 22, 2018

Tags will be included into config via concat::fragment on the agent5 config file /etc/dd-agent/datadog.conf. With agent6_enable set to true this concat file will never be defined causing an error in puppet:

Error: Failed to apply catalog: uninitialized constant Puppet::Type::Concat_file
Did you mean?  Puppet::Confine
@truthbk
Copy link
Member

truthbk commented Jan 22, 2018

@Deroin thanks for reporting this, I'm sorry you encoutered this. It looks like we'll have to patch the module to address this. Agent6 now relies on a different configuration, a YAML file, for it's configuration elements. I believe I may be able to provide a workaround soon - and a patch shortly after. Any chance you could share a snippet of the node configuration manifest that triggered the error? Please stay posted.

Thanks again! 🙇

@truthbk truthbk added this to the 2.0.0 milestone Jan 31, 2018
truthbk added a commit that referenced this issue Feb 5, 2018
Should _patch_ the problem described in #386. Doesn't provide
an alternative for agent6 though.
truthbk added a commit that referenced this issue Feb 27, 2018
* Transition to 2.0 dropping legacy + EOL compatibility fixes

* fixing multiple lint issues

* [agent6] tags currently unsupported on agent6

Should _patch_ the problem described in #386. Doesn't provide
an alternative for agent6 though.

* [agent6] add tagging support for agent6

Also removing gem provider options, should be the same for P4 and P5.

* [functions] tag6 return type unavailable on 4.6

* [spec] fixing spec tests to accomodate for refactor chagnges, improve coverage

* [skip ci] updating gitignore

* [apt] address beta repo management

* [apt] remove agent according to facts

* [reports] attempt switch to tkishel/system_gem provider for reporting

* [apt] set correct uri for keyserver

* Revert "[reports] attempt switch to tkishel/system_gem provider for reporting"

This reverts commit 9008acc.

* [ubuntu] default repo must be stable

* [rhel] set right repo for agent5/6

* [yum] allow overriding repo from init

* [rhel] fix downgrades/upgrades across repos

* [spec] fixing apm-related tests

* [yum] remove package on downgrade

* [yum] fix legacy, agent6 repo facts

* [apt] enable repo uri location override in main manifest

* [apt] actually pass location(repo) to ubuntu manifests

* [apt] allow configuring apt release

* [agent6] enabled process and apm configuration + extra options for agents.

* [agent6] single hash for additional options for all things agent6

* [lint] fix multiple linter issues

* [puppet][2.x] updating docs - skip ci
@marcomusso
Copy link

marcomusso commented May 22, 2018

As reported also on #421: this works for me on Puppet 3.x (on 1.12.1) and fixes also missing tags on agent6.

@marcomusso
Copy link

Any news on this? I just installed and agent with tag 2.3.0 of this repo on puppet 4.10 and I get an empty set of tags.

@marcomusso
Copy link

marcomusso commented Sep 10, 2018

Further comment on current master: docs seems to suggest that tags specified with the tags parameter can be merged with hiera ones ("allow merging"). But the code consider one OR the other.

cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this issue Apr 6, 2020
)

* Transition to 2.0 dropping legacy + EOL compatibility fixes

* fixing multiple lint issues

* [agent6] tags currently unsupported on agent6

Should _patch_ the problem described in DataDog#386. Doesn't provide
an alternative for agent6 though.

* [agent6] add tagging support for agent6

Also removing gem provider options, should be the same for P4 and P5.

* [functions] tag6 return type unavailable on 4.6

* [spec] fixing spec tests to accomodate for refactor chagnges, improve coverage

* [skip ci] updating gitignore

* [apt] address beta repo management

* [apt] remove agent according to facts

* [reports] attempt switch to tkishel/system_gem provider for reporting

* [apt] set correct uri for keyserver

* Revert "[reports] attempt switch to tkishel/system_gem provider for reporting"

This reverts commit 9008acc.

* [ubuntu] default repo must be stable

* [rhel] set right repo for agent5/6

* [yum] allow overriding repo from init

* [rhel] fix downgrades/upgrades across repos

* [spec] fixing apm-related tests

* [yum] remove package on downgrade

* [yum] fix legacy, agent6 repo facts

* [apt] enable repo uri location override in main manifest

* [apt] actually pass location(repo) to ubuntu manifests

* [apt] allow configuring apt release

* [agent6] enabled process and apm configuration + extra options for agents.

* [agent6] single hash for additional options for all things agent6

* [lint] fix multiple linter issues

* [puppet][2.x] updating docs - skip ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants