update kitchen tests (2) #832
Conversation
…ve legacy :: referencing. Changes for Puppet 8
… prettied the code.
…g no check for empty strings
… bcrypt_pbkdf 1.1 fails to install with Ruby 3.2.5
…ersionning not strings
…ss docs due to space between class declaration and docs
…to fanny/CECO-1954/puppet8
CI follow-ups
…as this no longer supports a String.
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
|
|
||
| # Ensures that a module is defined | ||
| # @param module_name Name of the module | ||
| def ensure_module_defined(module_name) |
There was a problem hiding this comment.
🔵 Code Quality Violation
Avoid top-level methods definition. Organize methods in modules/classes. (...read more)
This rule emphasizes the importance of organizing methods within modules or classes in Ruby. In Ruby, it's considered a best practice to wrap methods within classes or modules. This is because it helps in grouping related methods together, which in turn makes the code easier to understand, maintain, and reuse.
Not adhering to this rule can lead to a disorganized codebase, making it hard for other developers to understand and maintain the code. It can also lead to potential name clashes if a method is defined in the global scope.
To avoid violating this rule, always define your methods within a class or a module. For example, instead of writing def some_method; end, you should write class SomeClass def some_method; end end. This not only adheres to the rule but also improves the readability and maintainability of your code.
| 'full' => (RSpec::Support::OS.windows? ? '2019 SP1' : '14.04'), | ||
| }, | ||
| # Get parameters from catalogue. | ||
| def get_from_catalogue(type, name, parameter) |
There was a problem hiding this comment.
🔵 Code Quality Violation
Avoid top-level methods definition. Organize methods in modules/classes. (...read more)
This rule emphasizes the importance of organizing methods within modules or classes in Ruby. In Ruby, it's considered a best practice to wrap methods within classes or modules. This is because it helps in grouping related methods together, which in turn makes the code easier to understand, maintain, and reuse.
Not adhering to this rule can lead to a disorganized codebase, making it hard for other developers to understand and maintain the code. It can also lead to potential name clashes if a method is defined in the global scope.
To avoid violating this rule, always define your methods within a class or a module. For example, instead of writing def some_method; end, you should write class SomeClass def some_method; end end. This not only adheres to the rule but also improves the readability and maintainability of your code.
fanny-jiang
force-pushed
the
fanny/kitchen-tests-merge
branch
from
d0442d7 to
0926931
Compare
fanny-jiang
force-pushed
the
fanny/kitchen-tests-merge
branch
from
dc7e8d4 to
12d1de4
Compare
Gemfile
Outdated
| # https://github.com/ffi/ffi/issues/1103 (pin only for Ruby >= 2.5 as this version is not compatible below. ffi 1.17 is not compatible with Ruby 2.5: https://github.com/ffi/ffi/issues/1103) | ||
| if ruby_version >= Gem::Version.new('2.5') | ||
| gem "ffi", "= 1.16.3", platforms: [:ruby] | ||
| gem "rexml", '= 3.2.6', require: false |
There was a problem hiding this comment.
🔴 Library Vulnerability
rexml → 3.2.6
REXML ReDoS vulnerability (...read more)
What does this PR do?
Motivation
Additional Notes
Describe your test plan