Use patched AMI for Ubuntu 22 #1445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CelianR
approved these changes
Feb 26, 2025
vboulineau
reviewed
Feb 26, 2025
| @@ -141,6 +141,14 @@ func resolveUbuntuAMI(e aws.Environment, osInfo *os.Descriptor) (string, error) | |||
| volumeType = "ebs-gp3" | |||
| } | |||
|
|
|||
| // PATCH: Ubuntu 22.04 has a bugged version of curl. Use our own patched AMI instead | |||
| if osInfo.Version == "22.04" { | |||
There was a problem hiding this comment.
I understand that this is a one-shot image, which is not great to maintain. I also saw the PRs to upgrade to 24.04 reverted, what was the reason, can we work on fixing whatever prevents the upgrade?
There was a problem hiding this comment.
Yeah that's not really perfect.
However updating to Ubuntu 24.04 as a default seems to break a lot of test on datadog-agent. And we have some interest from Fleet team to keep some test running on Ubuntu 22.04 as well, and in the current situation the upstream Ubuntu 22.04 image brings flakiness in the CI
There was a problem hiding this comment.
Can we patch it at runtime perhaps, with a curl tarball stored in our S3, adding to the init script?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The curl version in Ubuntu seems to be buggy: https://stackoverflow.com/questions/72627218/openssl-error-messages-error0a000126ssl-routinesunexpected-eof-while-readin
It should reduce flakiness in our e2e tests
Images generated with: https://gitlab.ddbuild.io/DataDog/ami-builder/-/pipelines/56995600
Which scenarios this will impact?
Motivation
Additional Notes