You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
where is states that the return value of start-service is assigned to the services map. I prefer the documented version over the implemented one, but clearly this could not be fixed while maintaining backward compatibility. So maybe just update the doc?
The text was updated successfully, but these errors were encountered:
Sorry, but I had to make the code match the documentation, rather than the other way around. The reason is that start-service isn't just about side effects. It also has the chance to attach any information needed to finalize the service later. (E.g., system resources, log file names, etc.)
In line
https://github.com/Datomic/simulant/blob/master/src/simulant/sim.clj#L85
(doto (create-service ...) (start-service))
Since doto is used, the result of (create-service) is returned after (start-service) is called on it. This is not what is documented at
https://github.com/Datomic/simulant/blob/master/src/simulant/sim.clj#L69
where is states that the return value of start-service is assigned to the services map. I prefer the documented version over the implemented one, but clearly this could not be fixed while maintaining backward compatibility. So maybe just update the doc?
The text was updated successfully, but these errors were encountered: