Skip to content

Commit 01bd4c3

Browse files
Merge pull request #35 from DaveLiddament/fix/phpstan-v2-support
Fix PHPStan v2 support
2 parents c472adc + 874f9d5 commit 01bd4c3

13 files changed

+88
-4542
lines changed

.github/workflows/full-checks.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ jobs:
1919
matrix:
2020
dependencies:
2121
- "lowest"
22-
- "locked"
2322
- "highest"
2423
php-version:
2524
- "8.0"
@@ -56,10 +55,6 @@ jobs:
5655
if: ${{ matrix.dependencies == 'lowest' }}
5756
run: "composer update --prefer-lowest --no-interaction --no-progress"
5857

59-
- name: "Install locked dependencies"
60-
if: ${{ matrix.dependencies == 'locked' }}
61-
run: "composer install --no-interaction --no-progress"
62-
6358
- name: "Install highest dependencies"
6459
if: ${{ matrix.dependencies == 'highest' }}
6560
run: "composer update --no-interaction --no-progress"

build/PHPStan/Rules/CheckRuleIsInExtension.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace DaveLiddament\PhpstanPhpLanguageExtensions\Build\PHPStan\Rules;
44

5+
use DaveLiddament\PhpstanPhpLanguageExtensions\Helpers\Assert;
56
use Nette\Neon\Neon;
67
use PhpParser\Node;
78
use PHPStan\Analyser\Scope;
@@ -24,13 +25,17 @@ public function __construct()
2425
}
2526

2627
$services = $file['services'] ?? [];
28+
Assert::assertArray($services);
2729

2830
$classes = [];
2931
foreach ($services as $service) {
32+
Assert::assertArray($service);
3033
$class = $service['class'] ?? null;
3134
if (null === $class) {
3235
continue;
3336
}
37+
38+
Assert::assertString($class);
3439
$classes[] = $class;
3540
}
3641

@@ -68,7 +73,7 @@ public function processNode(Node $node, Scope $scope): array
6873
}
6974

7075
return [
71-
RuleErrorBuilder::message("Rule [$className] not in extension.neon.")->build(),
76+
RuleErrorBuilder::message("Rule [$className] not in extension.neon.")->identifier('phpstanExtensionLibrary.misconfigured')->build(),
7277
];
7378
}
7479
}

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
"type": "phpstan-extension",
66
"require": {
77
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
8-
"phpstan/phpstan": "^1.12 || ^2.0",
8+
"phpstan/phpstan": "^1.12.19 || ^2.0",
99
"dave-liddament/php-language-extensions": "^0.8.0 || ^0.9.0"
1010
},
1111
"require-dev": {
1212
"phpunit/phpunit": "^9.6.12",
1313
"friendsofphp/php-cs-fixer": "^3.26.1",
1414
"php-parallel-lint/php-parallel-lint": "^1.3.2",
15-
"dave-liddament/phpstan-rule-test-helper": "^0.4.0",
15+
"dave-liddament/phpstan-rule-test-helper": "^0.5.0",
1616
"nette/neon": "^3.4"
1717
},
1818
"license": "MIT",

0 commit comments

Comments
 (0)