Merge pull request #25 from DaveLiddament/fix/must-use-result-with-parent-and-self

FIX MustUseResult with parent and self

Author: DaveLiddament

src/Rules/MustUseResultRule.php

@@ -43,8 +43,10 @@ public function processNode(Node $node, Scope $scope): array
                 return [];
             }
 
+            $className = $scope->resolveName($class);
+
             $classReflections = [
-                $this->reflectionProvider->getClass($class->toCodeString()),
+                $this->reflectionProvider->getClass($className),
             ];
         } else {
             return [];

tests/Rules/MustUseResultOnMethodTest.php renamed to tests/Rules/MustUseResultTest.php

@@ -9,7 +9,7 @@
 use PHPStan\Rules\Rule;
 
 /** @extends AbstractRuleTestCase<MustUseResultRule> */
-final class MustUseResultOnMethodTest extends AbstractRuleTestCase
+final class MustUseResultTest extends AbstractRuleTestCase
 {
     protected function getRule(): Rule
     {
@@ -30,6 +30,11 @@ public function testMustUseResultRuleOnStaticMethod(): void
         );
     }
 
+    public function testMustUseWithParent(): void
+    {
+        $this->assertIssuesReported(__DIR__.'/data/mustUseResult/mustUseResultWithParent.php');
+    }
+
     protected function getErrorFormatter(): string
     {
         return 'Result returned by method must be used';

tests/Rules/data/mustUseResult/mustUseResultWithParent.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace MustUseResultWithParent {
+
+
+    use DaveLiddament\PhpLanguageExtensions\MustUseResult;
+
+
+    class Shape
+    {
+
+        public function __construct(
+        ) {
+        }
+    }
+
+
+    class Circle extends Shape
+    {
+
+        public function __construct(
+        ) {
+            parent::__construct();
+        }
+    }
+}