Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Reduce the amount of duplicate vertices #13

Open
DavidArayan opened this issue Mar 22, 2018 · 0 comments
Open

[Feature] - Reduce the amount of duplicate vertices #13

DavidArayan opened this issue Mar 22, 2018 · 0 comments
Assignees

Comments

@DavidArayan
Copy link
Owner

Currently the slicer will duplicate all vertices (including the triangles which fail an intersection). This has been done for performance and code readability reasons. There is an opportunity to optimize this section of the code to ensure that sliced mesh output has minimal duplicated vertices.

  1. Change the Convex Triangulator to output Triangles in such a way that the vertices are shared instead of duplicated.
  2. Change the slicer so that triangles which fail an intersection test (fail to cut) will not have vertices needlessly duplicated.

As an addition can have a look to see if sliced triangles can also share vertices, however this would require some expensive checks/sorts which could hinder performance. May add it as an optional feature instead of making it part of the core slicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant